From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#30823: 25.3; modification-hooks of overlays are not run in some cases Date: Thu, 30 Aug 2018 23:14:53 -0400 Message-ID: <875zzrrzv6.fsf@gmail.com> References: <83lgetri7r.fsf@gnu.org> <87in9cpd3a.fsf@gmail.com> <87in48ww9l.fsf@gmail.com> <83o9e0f9uj.fsf@gnu.org> <87tvnluvp4.fsf@gmail.com> <83bm9tb2yj.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1535685251 1796 195.159.176.226 (31 Aug 2018 03:14:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 31 Aug 2018 03:14:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: victorhge@gmail.com, 30823@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 31 05:14:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvZss-0000Lm-CE for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Aug 2018 05:14:06 +0200 Original-Received: from localhost ([::1]:51691 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fvZuy-0005aj-Oh for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Aug 2018 23:16:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fvZuo-0005aT-3P for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2018 23:16:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fvZuk-0005Ty-Sp for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2018 23:16:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34629) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fvZuk-0005Tm-Ku for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2018 23:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fvZuk-0007dI-Ds for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2018 23:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Aug 2018 03:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30823-submit@debbugs.gnu.org id=B30823.153568530529228 (code B ref 30823); Fri, 31 Aug 2018 03:16:02 +0000 Original-Received: (at 30823) by debbugs.gnu.org; 31 Aug 2018 03:15:05 +0000 Original-Received: from localhost ([127.0.0.1]:39646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvZtp-0007bL-5F for submit@debbugs.gnu.org; Thu, 30 Aug 2018 23:15:05 -0400 Original-Received: from mail-it0-f53.google.com ([209.85.214.53]:52645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvZtn-0007aT-Mk for 30823@debbugs.gnu.org; Thu, 30 Aug 2018 23:15:04 -0400 Original-Received: by mail-it0-f53.google.com with SMTP id h3-v6so5407329ita.2 for <30823@debbugs.gnu.org>; Thu, 30 Aug 2018 20:15:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=9zNU3PQaMzaQjZTHMeZCNmIH3MGWQSgDQfUr0YJTM2c=; b=o/qd7c6QSKk5Bai4jphbC3WqUHG7+a5yl80KOywb56wj6OYnsE7fbX4GHAYwA7rUpG ROKTuzI51zF2mWcyekhNeECyoHuIQLFh29BrkmXqnslmROibJqBye/Dn4JW09F9LjP2D 05Vnnv6MqD00/EGVkpDGBkHVYKenfeLpnLLDZkPZ6a816feOiIEKooCzs3qIPBHiW/D8 sKANbcrbpYZGWmf2TZi3ewOt7MYB52F94gR7MAv69D2XzPGd5QcLyAxYJ3oCHhRc6e0h VlStQkVR+9KYqG0sdRMRg6NwtuotySmXuZJW7CR1eVWhPPKYStUt3Rg/co8rRKXU8Bro z+5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=9zNU3PQaMzaQjZTHMeZCNmIH3MGWQSgDQfUr0YJTM2c=; b=G4SLDHZN42nPUoll+cAWnjkhQETVtJZI71USrgcGOelLBre24sBEHq7x7jeRj51cjN MW+80/owPiVKmoDhJkgqHLkWZ/2sqtgcsATmUrbbEgH5DjdEUyaog/pgACV8+brQP0Wu 1bSwVzulUNRdvctis4Bom8iig5zEvjarnpxmPooltGu3xuLsY08bMpvlZdmlzICqrBN6 uTol1aysOdzX/WF9Tr8fpJQax9kAMbja9VN09nDxY1xHgN9QXLJjLZg0hLczdieM/df/ tNhZPOikfsym1b+8WCGojGc7hyNEA4qQ4wIucuvBd8xUHis4+5XvSvl1UXuT8DnymKvb Le6A== X-Gm-Message-State: APzg51AMCeMmYZUQwxu4bBKlheKBvVRceQ+esCUIZiLT1cP1PqZRwzX5 f9QJ04tPQdsZ1bXNC4JgU6c= X-Google-Smtp-Source: ANB0VdaIRvdHTlzN46CsI1vl7kyhd/+JpdHCX+/tMT3Y9nRIK2R6kLY5rpvzHsrqVQPs4A4Uzsz3KQ== X-Received: by 2002:a24:46cd:: with SMTP id j196-v6mr4038798itb.0.1535685298285; Thu, 30 Aug 2018 20:14:58 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i2-v6sm3349472ioh.80.2018.08.30.20.14.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Aug 2018 20:14:56 -0700 (PDT) In-Reply-To: <83bm9tb2yj.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 23 Aug 2018 16:57:24 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149908 Archived-At: Eli Zaretskii writes: >> From: Noam Postavsky >> Cc: victorhge@gmail.com, 30823@debbugs.gnu.org, monnier@iro.umontreal.ca >> Date: Thu, 23 Aug 2018 08:13:59 -0400 >> >> Eli Zaretskii writes: >> >> > Btw, I'm somewhat worried by the solution being proposed: it removes a >> > general safety device and replaces it by a solution that targets only >> > bug#21824, a much narrower class of problems. Is that wise? >> >> IMO, a safety device which causes new bugs is disqualified from its job. > > I'm not sure it caused a new bug. It causes it in the sense that reverting the fix for #21284 stops this new bug from happening. > I'm hard pressed for free time lately, so I'd be grateful if you could > see whether it would be possible to make the original change smarter, > so that it avoids causing the current issue. If not, I will try to > look into it in a couple of weeks or so. > >> Furthermore, we're currently calling the after change hooks without >> the before change hooks which is just asking for trouble (as >> exemplified by Bug#21824 and this one). > > That's a separate issue, isn't it? We could refrain from calling the > after-change hooks as well. It's not a separate issue. The original reason for #21824 is that we called the after-change hooks without doing the setup (i.e., passing PREPARE=false to del_range_both). With the addition of the "safety device", #21824 is avoided, but this bug is caused instead. Refraining from calling after-change hooks is exactly what my patch does, this fixes both cases. This makes the "safety device" redundant, but with the after-change suppression added it doesn't do any harm; so if you insist, we can leave it in. I don't think it's a good idea to have such things cluttering up the source though.