From: Noam Postavsky <npostavs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: victorhge@gmail.com, 30823@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#30823: 25.3; modification-hooks of overlays are not run in some cases
Date: Thu, 30 Aug 2018 23:14:53 -0400 [thread overview]
Message-ID: <875zzrrzv6.fsf@gmail.com> (raw)
In-Reply-To: <83bm9tb2yj.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 23 Aug 2018 16:57:24 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Noam Postavsky <npostavs@gmail.com>
>> Cc: victorhge@gmail.com, 30823@debbugs.gnu.org, monnier@iro.umontreal.ca
>> Date: Thu, 23 Aug 2018 08:13:59 -0400
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> > Btw, I'm somewhat worried by the solution being proposed: it removes a
>> > general safety device and replaces it by a solution that targets only
>> > bug#21824, a much narrower class of problems. Is that wise?
>>
>> IMO, a safety device which causes new bugs is disqualified from its job.
>
> I'm not sure it caused a new bug.
It causes it in the sense that reverting the fix for #21284 stops this
new bug from happening.
> I'm hard pressed for free time lately, so I'd be grateful if you could
> see whether it would be possible to make the original change smarter,
> so that it avoids causing the current issue. If not, I will try to
> look into it in a couple of weeks or so.
>
>> Furthermore, we're currently calling the after change hooks without
>> the before change hooks which is just asking for trouble (as
>> exemplified by Bug#21824 and this one).
>
> That's a separate issue, isn't it? We could refrain from calling the
> after-change hooks as well.
It's not a separate issue. The original reason for #21824 is that we
called the after-change hooks without doing the setup (i.e., passing
PREPARE=false to del_range_both). With the addition of the "safety
device", #21824 is avoided, but this bug is caused instead. Refraining
from calling after-change hooks is exactly what my patch does, this
fixes both cases.
This makes the "safety device" redundant, but with the after-change
suppression added it doesn't do any harm; so if you insist, we can leave
it in. I don't think it's a good idea to have such things cluttering up
the source though.
next prev parent reply other threads:[~2018-08-31 3:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 4:15 bug#30823: 25.3; modification-hooks of overlays are not run in some cases Ren Victor
2018-03-15 6:00 ` Eli Zaretskii
2018-03-15 7:29 ` Ren Victor
2018-03-31 13:51 ` Noam Postavsky
2018-08-17 20:52 ` Noam Postavsky
2018-08-18 6:49 ` Eli Zaretskii
2018-08-19 3:48 ` Stefan Monnier
2018-08-19 14:46 ` Eli Zaretskii
2018-08-19 15:43 ` Stefan Monnier
2018-08-19 16:13 ` Eli Zaretskii
2018-08-20 3:02 ` Richard Stallman
2018-08-20 16:37 ` Eli Zaretskii
2018-08-19 20:46 ` Stefan Monnier
2018-08-20 16:34 ` Eli Zaretskii
2018-08-23 12:13 ` Noam Postavsky
2018-08-23 13:57 ` Eli Zaretskii
2018-08-31 3:14 ` Noam Postavsky [this message]
2018-08-31 14:25 ` Eli Zaretskii
2018-09-01 16:38 ` Noam Postavsky
2018-09-11 11:59 ` Eli Zaretskii
2018-09-13 1:34 ` Noam Postavsky
2018-09-13 13:43 ` Eli Zaretskii
2018-09-14 12:03 ` Noam Postavsky
2018-09-15 9:23 ` Eli Zaretskii
2018-09-15 14:10 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zzrrzv6.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=30823@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=victorhge@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).