From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31289: madx mode for emacs Date: Wed, 24 Oct 2018 18:30:56 -0400 Message-ID: <875zxrm0yn.fsf@gmail.com> References: <87d0wjr6dv.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1540420211 29052 195.159.176.226 (24 Oct 2018 22:30:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 24 Oct 2018 22:30:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 31289@debbugs.gnu.org To: Oscar Blanco Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 25 00:30:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFRfB-0007Q1-Af for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Oct 2018 00:30:05 +0200 Original-Received: from localhost ([::1]:50788 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFRhH-0004eJ-Qd for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Oct 2018 18:32:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFRh9-0004eD-0P for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2018 18:32:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFRh4-0005P5-Uj for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2018 18:32:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36713) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gFRh4-0005Oo-PE for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2018 18:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gFRh4-0008Hr-CT for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2018 18:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Oct 2018 22:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31289 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31289-submit@debbugs.gnu.org id=B31289.154042026631783 (code B ref 31289); Wed, 24 Oct 2018 22:32:02 +0000 Original-Received: (at 31289) by debbugs.gnu.org; 24 Oct 2018 22:31:06 +0000 Original-Received: from localhost ([127.0.0.1]:40970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFRg9-0008GZ-Kg for submit@debbugs.gnu.org; Wed, 24 Oct 2018 18:31:05 -0400 Original-Received: from mail-it1-f173.google.com ([209.85.166.173]:55353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFRg7-0008G6-UQ for 31289@debbugs.gnu.org; Wed, 24 Oct 2018 18:31:04 -0400 Original-Received: by mail-it1-f173.google.com with SMTP id c23-v6so8214045itd.5 for <31289@debbugs.gnu.org>; Wed, 24 Oct 2018 15:31:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jKfO1m3cm6Yk8DoNIWKhTbhQDIPPNko1OzLGd0rCbyk=; b=E/Z9bp9BANB97XcG/qd+ZBjQIhzmDnOMvOqS1dI9mMlEkKYn68tgo8WcdleL2SY75+ vNZn8Uuf2Ossx4iFqwZUeEX/5+HQBSZmbzBAgVjNltXfVoVRRxIYiSjWkQdbRh59gLeL G64Ym6An6/iRbk/9GinHRL4BU9B+rvLSIi60xz5OKYmk4mA9khxW+pLmoi2FW+AcU2xR fV1PKOmrMYoq7tEnwKuJlEv4Nw7b7nsxdtSUoWD1JfbJf/a3MWDvGeRwu5b3wUyg9+Rs L/1FeeEAUSdvBuh16rgmkaOeupAhqkONISlhlDTTRe0HB6Fr544sEArDpkDNa+T/sCse xGgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=jKfO1m3cm6Yk8DoNIWKhTbhQDIPPNko1OzLGd0rCbyk=; b=BOMKNWZaq1RU0lLyekSAHi0e9s33fUXkhyLhjxuFo2jsLtvpNwNsPEODdlewssRwjg jbSoHnqd93pDdaMweGtNSt/GbhyMaqalvFD/6PnYA/Smm+X2512zW85CPShRhiBDPSPC vVIny0AY95/NmxG1l5QfFrzf5nv11Gi5Kqnufndu+0jk5xOOWo2yDAqj2T3ZuHS4Bqy+ BXJxLefa9O9W7hrbzNizfkCxcKwAEhMH94nCHoXjAHBvueU/0RRWV9WUDFhrl3Qj+0RK xXkLc2/JKl7qeFHl1xWYBCXoOo1cp0wM14RE23zmwE2kvmNOpinaji+MN0osKTWtHzLe 7YRg== X-Gm-Message-State: AGRZ1gLZ9Kbq7py9mr2qqLZ9RjBwWyY/TM+bitMCk5m22g2P6opC13Sq ipJsGJwO8UeQSI8G0AdslVKfs6E9 X-Google-Smtp-Source: AJdET5fBGzgvR0uTGUNV9CC+PqN383PoowfbfzFcfJABG+JM4bGlDjXki61oPv5BqpV/odd9LuJF/A== X-Received: by 2002:a02:8a08:: with SMTP id j8-v6mr3112184jak.46.1540420258279; Wed, 24 Oct 2018 15:30:58 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 129-v6sm4452483itl.43.2018.10.24.15.30.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Oct 2018 15:30:57 -0700 (PDT) In-Reply-To: (Oscar Blanco's message of "Fri, 5 Oct 2018 08:52:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151574 Archived-At: Oscar Blanco writes: > I attached again the script with the corresponding modifications. I > understand that an additional script called madx-autoloads.el is required. The madx-autoloads.el will be generated when installing the package from forms that are prefix with ;;;###autoload See `(elisp) Autoload'. You can test it out using M-x package-install-file. > ;;; madx.el --- Major mode for editing MAD-X files in Emacs > ;; Copyright (C) 2013, 2016 Oscar BLANCO > ;; 2017, 2018 FSF You don't seem to be listed in copyright assignment file; to officially assign copyright to the FSF you need to sign some legal papers. Instructions to begin the process are at https://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.future > (defconst madx-font-lock-keywords-face-all > ;; madx-font-lock-keywords-programflow > `((,(regexp-opt '(;; font-lock-keyword-face > ;; madx-font-lock-keywords-programflow > "IF" > "ELSEIF" > "ELSE" > "WHILE" > "MACRO" > ) 'words) I would prefer the close paren grouped with the sexp it closes, as in `((,(regexp-opt '(;; font-lock-keyword-face ;; madx-font-lock-keywords-programflow "IF" "ELSEIF" "ELSE" "WHILE" "MACRO") 'words) . font-lock-keyword-face)) > ;; some variables already optimized > "\\|RE[1-6][1-6]" > "\\|T[1-6][1-6][1-6]" > "\\|TM[1-6][1-6][1-6]" These two could be written as just "\\|TM?[1-6][1-6][1-6]" > "\\||BETA[1-3][1-3]" > "\\|BETA[1-3][1-3]P" I guess that extra "|" is a typo; again you could coalesce these into "\\|BETA[1-3][1-3]P?", similar for the following ones. > "\\|ALFA[1-3][1-3]" > "\\|ALFA[1-3][1-3]P" > "\\|GAMA[1-3][1-3]" > "\\|GAMA[1-3][1-3]P" > "\\|GAMA[1-3][1-3]" > "\\|DISP[1-4]P[1-3]" > "\\|EIGN[1-6][1-6]" > "\\|R[1-6][1-6]" > "\\|RM[1-6][1-6]") > . font-lock-variable-name-face)) > "Highlighting expressions for MAD-X mode (variable-name-all).") > (define-derived-mode madx-mode fundamental-mode "madx" > "Major mode for editing Methodical Accelerator Design X script files." > (kill-all-local-variables) > ;; (use-local-map madx-mode-map) > (set-syntax-table madx-mode-syntax-table) define-derived-mode already does kill-all-local-variables, use-local-map, and set-syntax-table, so you don't need to put them here.