From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#33263: 27.0.50; Tidying up Gnus modes Date: Mon, 05 Nov 2018 09:14:25 -0500 Message-ID: <875zxbipby.fsf@gmail.com> References: <877ehs1bgq.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1541427189 12046 195.159.176.226 (5 Nov 2018 14:13:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 5 Nov 2018 14:13:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 33263@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 05 15:13:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJfck-0002xQ-G5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Nov 2018 15:13:02 +0100 Original-Received: from localhost ([::1]:35503 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJfeq-0006Mu-Qk for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Nov 2018 09:15:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60724) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJfek-0006Mo-8T for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2018 09:15:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJfeg-00019D-UQ for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2018 09:15:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58682) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gJfeg-00018C-MO for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2018 09:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gJfeg-0001bJ-AR for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2018 09:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Nov 2018 14:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33263 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33263-submit@debbugs.gnu.org id=B33263.15414272756106 (code B ref 33263); Mon, 05 Nov 2018 14:15:02 +0000 Original-Received: (at 33263) by debbugs.gnu.org; 5 Nov 2018 14:14:35 +0000 Original-Received: from localhost ([127.0.0.1]:34707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJfeE-0001aP-Qp for submit@debbugs.gnu.org; Mon, 05 Nov 2018 09:14:35 -0500 Original-Received: from mail-it1-f177.google.com ([209.85.166.177]:38774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJfeC-0001aC-Oe for 33263@debbugs.gnu.org; Mon, 05 Nov 2018 09:14:33 -0500 Original-Received: by mail-it1-f177.google.com with SMTP id k141-v6so10913387itk.3 for <33263@debbugs.gnu.org>; Mon, 05 Nov 2018 06:14:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=YFWy3MBSQ3FyeGqqxKsrr/SWq3Cgy49Xcm7hMvLm9Ew=; b=drR/Q+ZIeXin262AhNlQAp1JIFfrEU7saHanwEzsO8TWFkpIVKAyL98viq97J93kz4 ac7rzxFcfjXC2vJ8AoDT7B+idIhr5Tw+/60KtCqylpjo5AJqgKhCxI9UjEIj/q8/v3HE KDj3RP0VEo7mAF/WEQIR2uiqZQbRyL/V1ELk2x+l87K9yVCZ9+GwUgz3c+IG4B6428CR oLjcZDqsmWuCuYcIqQiXrXQyPJi39Yf5yamDdczxbz/KTNCNNrlDuq1lqy0gatcpC5fj CUvmldWFJZilc9XVeVzx0z/l0X9JB4TdZoH/56cjLgOzlQeDtmT4KTFaWQdsMDARuvdt FGsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=YFWy3MBSQ3FyeGqqxKsrr/SWq3Cgy49Xcm7hMvLm9Ew=; b=gYsPrBkQ4QAOUdjICLjM3FOltsjKqy1BdVQ+KZ3JwiSadQFlvbccz24uYkLLkBwnPt FZjDUQJMjd78YEdEipdLYOrT1O0dvQJKpts+NWJEPinXWtB8Q17dn38n/61XYsVD1YFI WnmS+f9GkqLDFFZpGbWS9UP+ISb4VVF02MjAyKGZEEaOPzlOvXrpl8iVBUWJhyrPQ30S LCOrs2Ewma8nnTRauY0Vz7/4L/cyS2/7hjwOtgj4WijesizU7+SAlAaYnf9CCa1CRlV+ iIXs2ug1qBQkdKBs9jJVNYh/Eiza79bybfjvc6q30p9tj/Rlo0bsmIDnYmCSHJgfftd4 hC1A== X-Gm-Message-State: AGRZ1gKCrRoj9V2Et9RiqgLl6K9wKpooJ38Y3z6nvXn5tdpsKmpedqWS O/xAdSTzO5PSE/f6bEiJ+oH9dN4A X-Google-Smtp-Source: AJdET5ds2zG6ov/kCqQAXfKrROSD0o6BYH5bk00lsUN+D6BN4LG00qj9r5uehZKe4zXkCpxb1JMbcw== X-Received: by 2002:a02:664c:: with SMTP id l12-v6mr19522580jaf.103.1541427266782; Mon, 05 Nov 2018 06:14:26 -0800 (PST) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id b88-v6sm9231891itd.44.2018.11.05.06.14.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Nov 2018 06:14:26 -0800 (PST) In-Reply-To: <877ehs1bgq.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 04 Nov 2018 18:53:41 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152053 Archived-At: Eric Abrahamsen writes: > +(defvar gnus-browse-mode-map (make-keymap)) > > (unless gnus-browse-mode-map > - (setq gnus-browse-mode-map (make-keymap)) > + (defvar gnus-browse-mode-map (make-keymap)) This doesn't look right. > -(defun gnus-summary-mode (&optional group) > +(define-derived-mode gnus-summary-mode gnus-mode "Summary" > "Major mode for reading articles. > - (gnus-summary-mode group) > + (setq gnus-newsgroup-name group) > + (gnus-summary-mode) > (when (gnus-group-quit-config group) Where does GROUP come from now?