From: Juri Linkov <juri@linkov.net>
To: Drew Adams <drew.adams@oracle.com>
Cc: 15839@debbugs.gnu.org
Subject: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily
Date: Wed, 28 Nov 2018 02:35:53 +0200 [thread overview]
Message-ID: <875zwidonq.fsf@mail.linkov.net> (raw)
In-Reply-To: <8af20443-841d-4211-99ae-269e042a9a33@default> (Drew Adams's message of "Mon, 26 Nov 2018 16:49:21 -0800 (PST)")
> I don't want to customize one variable to be able to
> scroll farther, and another variable to have what's
> shown by that scrolling have lazy-highlighting
> (especially if the latter requires lazy-highlighting
> the entire buffer, rather than just what I see when
> scrolling).
Fine. If you are lazy to customize two variables,
after you customize one variable we could automatically
change the value of the second variable.
> I want to be able to use `isearch-allow-scroll' to
> let me scroll as far as I want, and see search hits
> lazy-highlighted in what parts of the buffer I
> scroll to.
Fine, we could allow the same feature to be enabled
by two different variables.
diff --git a/lisp/isearch.el b/lisp/isearch.el
index eb0b25f9b1..ac809e4980 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -2747,8 +2747,15 @@ isearch-allow-scroll
"Whether scrolling is allowed during incremental search.
If non-nil, scrolling commands can be used in Isearch mode.
However, the current match will never scroll offscreen.
+If `unlimited', the current match can scroll offscreen.
+This has the same effect as the value `nil' of `search-exit-option'.
If nil, scrolling commands will first cancel Isearch mode."
- :type 'boolean
+ :type '(choice boolean
+ (const :tag "Can scroll offscreen" unlimited))
+ :set (lambda (sym val)
+ (set sym val)
+ (when (eq val 'unlimited)
+ (setq lazy-highlight-buffer t)))
:group 'isearch)
(defcustom isearch-allow-prefix t
@@ -2841,11 +2848,11 @@ isearch-pre-command-hook
((or (and isearch-allow-prefix
(memq this-command '(universal-argument universal-argument-more
digit-argument negative-argument)))
- (and isearch-allow-scroll
+ (and isearch-allow-scroll (not (eq isearch-allow-scroll 'unlimited))
(symbolp this-command)
(or (eq (get this-command 'isearch-scroll) t)
(eq (get this-command 'scroll-command) t))))
- (when isearch-allow-scroll
+ (when (and isearch-allow-scroll (not (eq isearch-allow-scroll 'unlimited)))
(setq isearch-pre-scroll-point (point))))
;; A mouse click on the isearch message starts editing the search string.
((and (eq (car-safe main-event) 'down-mouse-1)
@@ -2853,6 +2860,7 @@ isearch-pre-command-hook
;; Swallow the up-event.
(read-event)
(setq this-command 'isearch-edit-string))
+ ((eq isearch-allow-scroll 'unlimited))
;; Don't terminate the search for motion commands.
((or (and (eq search-exit-option 'move)
(symbolp this-command)
next prev parent reply other threads:[~2018-11-28 0:35 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 23:02 bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Drew Adams
2013-11-09 0:57 ` Juri Linkov
2013-11-09 3:09 ` Drew Adams
2013-11-10 13:46 ` Stefan Monnier
2013-11-10 16:52 ` Drew Adams
2013-11-11 19:08 ` Drew Adams
2018-11-24 22:45 ` Juri Linkov
2018-11-25 3:14 ` Drew Adams
2018-11-25 20:15 ` Juri Linkov
2018-11-26 0:16 ` Drew Adams
2018-11-26 23:35 ` Juri Linkov
2018-11-27 0:49 ` Drew Adams
2018-11-28 0:35 ` Juri Linkov [this message]
2018-11-28 15:15 ` Drew Adams
2018-11-28 23:01 ` Juri Linkov
2018-11-29 3:36 ` Drew Adams
2018-11-29 22:23 ` Juri Linkov
2018-11-30 0:27 ` Drew Adams
2018-11-30 7:28 ` Eli Zaretskii
[not found] ` <<83lg5bc9d6.fsf@gnu.org>
2018-11-30 15:33 ` Drew Adams
2018-12-04 0:29 ` Juri Linkov
2018-12-04 14:46 ` Drew Adams
2018-12-04 20:46 ` Drew Adams
2018-12-04 21:38 ` Juri Linkov
2018-12-05 0:32 ` Drew Adams
2018-12-05 23:44 ` Juri Linkov
2018-12-06 1:20 ` Drew Adams
2018-12-05 12:59 ` Michael Heerdegen
2018-12-05 23:49 ` Juri Linkov
2018-12-06 12:15 ` Michael Heerdegen
2018-12-06 23:03 ` Juri Linkov
2018-12-07 12:42 ` Michael Heerdegen
2018-12-08 23:38 ` Juri Linkov
2018-12-09 1:13 ` Michael Heerdegen
2018-12-10 0:21 ` Juri Linkov
2018-12-10 0:58 ` Michael Heerdegen
2018-12-11 0:37 ` Juri Linkov
2018-12-11 18:22 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zwidonq.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=15839@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).