bug#33619: 26.1.90; Tramp "simplified" syntax completion problem

bug#33619: 26.1.90; Tramp "simplified" syntax completion problem

[David Hull]

[-- Attachment #1: Type: text/plain, Size: 3900 bytes --]

Filename completion does not work with tramp's "simplified" syntax.

  (load-library "tramp")
  (tramp-change syntax 'simplified)

Now if I run find-file and type "//cos6:src/ss" and then TAB I get the
error:

  completion--some: Wrong type argument: stringp, ""

(My remote host is named "cos6" and it has a "src/ssrtb-server" directory.)

If I set the the tramp-syntax back to 'default then completion works.
Completion worked with the "simplified" syntax in emacs 26.1.



In GNU Emacs 26.1.90 (build 1, x86_64-apple-darwin18.2.0, NS appkit-1671.10
Version 10.14.1 (Build 18B75))
 of 2018-12-03 built on mbp-109-op-04
Repository revision: 8d7e58ce9f389d77323e0237c22c4e13cb68b8e7
Windowing system distributor 'Apple', version 10.3.1671
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Quit [3 times]
Making completion list...
Loading tramp...done
completion--some: Wrong type argument: stringp, ""
Quit [3 times]
Configured using:
 'configure --with-ns '--enable-locallisppath=/Library/Application
 Support/Emacs/${version}/site-lisp:/Library/Application
 Support/Emacs/site-lisp' --with-modules'

Configured features:
JPEG DBUS NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES
THREADS

Important settings:
  value of $EMACSDATA:
/Users/david.hull/Applications/Emacs.app/Contents/Resources/etc
  value of $EMACSLOADPATH:
/Users/david.hull/Applications/Emacs.app/Contents/Resources/lisp:/Users/david.hull/Applications/Emacs.app/Contents/Resources/lisp/leim
  value of $LC_COLLATE: C
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Fundamental

Minor modes in effect:
  shell-dirtrack-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny seq dired
dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util
rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils tramp-cache tramp-sh cus-edit easymenu
cus-start cus-load wid-edit tramp-cmds tramp tramp-compat tramp-loaddefs
trampver shell pcomplete comint ansi-color ring parse-time format-spec
advice auth-source cl-seq eieio byte-opt bytecomp byte-compile cconv
eieio-core cl-macs gv eieio-loaddefs cl-loaddefs cl-lib password-cache
elec-pair time-date tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util
term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow isearch timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind kqueue cocoa ns multi-tty
make-network-process emacs)

Memory information:
((conses 16 237760 12374)
 (symbols 48 23427 1)
 (miscs 40 71 206)
 (strings 32 39299 1776)
 (string-bytes 1 1132795)
 (vectors 16 39286)
 (vector-slots 8 771090 18152)
 (floats 8 73 64)
 (intervals 56 230 0)
 (buffers 992 13))

[-- Attachment #2: Type: text/html, Size: 4382 bytes --]

bug#33619: 26.1.90; Tramp "simplified" syntax completion problem

[Michael Albinus]

David Hull <david.hull@openx.com> writes:

Hi David,

Thanks for the report.

> Filename completion does not work with tramp's "simplified" syntax.
>
>   (load-library "tramp")
>   (tramp-change syntax 'simplified)
>
> Now if I run find-file and type "//cos6:src/ss" and then TAB I get the
> error:
>
>   completion--some: Wrong type argument: stringp, ""
>
> (My remote host is named "cos6" and it has a "src/ssrtb-server"
> directory.)
>
> If I set the the tramp-syntax back to 'default then completion works.
> Completion worked with the "simplified" syntax in emacs 26.1.

I've tried to reproduce it with the current emacs-26 branch on an Ubuntu
18.10 machine. You're on a macOS machine, but this shouldn't matter.

The problem doesn't happen to me.

Could you pls start "emacs -Q -l tramp", change the Tramp syntax, and
try to reproduce the problem? Does it still happen?

In case of yes, could you perform (setq debug-on-error t) prior the
test, and show the resulting backtrace?

Thanks, and best regards, Michael.

bug#33619: 26.1.90; Tramp "simplified" syntax completion problem

[Andreas Schwab]

On Dez 04 2018, David Hull <david.hull@openx.com> wrote:

> Filename completion does not work with tramp's "simplified" syntax.
>
>   (load-library "tramp")
>   (tramp-change syntax 'simplified)
>
> Now if I run find-file and type "//cos6:src/ss" and then TAB I get the
> error:
>
>   completion--some: Wrong type argument: stringp, ""

This is fixed by commit b8b42c2315.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

bug#33619: 26.1.90; Tramp "simplified" syntax completion problem

[Michael Albinus]

Andreas Schwab <schwab@linux-m68k.org> writes:

> On Dez 04 2018, David Hull <david.hull@openx.com> wrote:
>
>> Filename completion does not work with tramp's "simplified" syntax.
>>
>>   (load-library "tramp")
>>   (tramp-change syntax 'simplified)
>>
>> Now if I run find-file and type "//cos6:src/ss" and then TAB I get the
>> error:
>>
>>   completion--some: Wrong type argument: stringp, ""
>
> This is fixed by commit b8b42c2315.

Indeed, you've backported this fix to the emacs-26 branch. The bug
report tells us

--8<---------------cut here---------------start------------->8---
In GNU Emacs 26.1.90 (build 1, x86_64-apple-darwin18.2.0, NS
appkit-1671.10 Version 10.14.1 (Build 18B75))
 of 2018-12-03 built on mbp-109-op-04
Repository revision: 8d7e58ce9f389d77323e0237c22c4e13cb68b8e7
--8<---------------cut here---------------end--------------->8---

Hmm, a git commit 8d7e58ce9f389d77323e0237c22c4e13cb68b8e7 does not
exist in emacs-26 or master branches.

> Andreas.

Best regards, Michael.

bug#33619: 26.1.90; Tramp "simplified" syntax completion problem

[David Hull]

[-- Attachment #1: Type: text/plain, Size: 6136 bytes --]

My emacs was built from a tarball I downloaded from
http://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-26.1.90.tar.gz. I
believe this is commit 7851ae8b443c62a41ea4f4440512aa56cc87b9b7. It looks
like this does not have the change made in commit
8d7e58ce9f389d77323e0237c22c4e.
Here is the backtrace from my current build as requested. I will also try
applying the fix from 8d7e58ce9f389d77323e0237c22c4e and test again.

I ran "emacs -Q -l tramp", then in the *scratch* buffer:

(emacs-version)
"GNU Emacs 26.1.90 (build 1, x86_64-apple-darwin18.2.0, NS appkit-1671.10
Version 10.14.1 (Build 18B75))\n of 2018-12-03"
(tramp-change-syntax 'simplified)
simplified
(setq debug-on-error t)
t

Then when I typed (from "view-lossage"):

 C-x C-f [find-file]
 / [self-insert-command]
 c [self-insert-command]
 o [self-insert-command]
 s [self-insert-command]
 6 [self-insert-command]
 : [self-insert-command]
 s [self-insert-command]
 r [self-insert-command]
 c [self-insert-command]
 / [self-insert-command]
 s [self-insert-command]
 s [self-insert-command]
 <tab> [minibuffer-complete]

I got the error:

Debugger entered--Lisp error: (wrong-type-argument stringp "")
  signal(wrong-type-argument (stringp ""))
  completion--some(#f(compiled-function (style) #<bytecode 0x40e7eafd>)
(basic partial-completion emacs22))
  completion--nth-completion(1 "~//cos6:src/ss" read-file-name-internal
file-exists-p 14 (metadata (category . file) (completion--unquote-requote .
t)))
  completion-try-completion("~//cos6:src/ss" read-file-name-internal
file-exists-p 14 (metadata (category . file) (completion--unquote-requote .
t)))
  completion--do-completion(12 26)
  completion--in-region-1(12 26)
  #f(compiled-function (start end collection predicate) #<bytecode
0x400c2e6b>)(12 26 read-file-name-internal file-exists-p)
  apply(#f(compiled-function (start end collection predicate) #<bytecode
0x400c2e6b>) (12 26 read-file-name-internal file-exists-p))
  #f(compiled-function (funs global args) #<bytecode 0x40e6bd1d>)(nil nil
(12 26 read-file-name-internal file-exists-p))
  completion--in-region(12 26 read-file-name-internal file-exists-p)
  completion-in-region(12 26 read-file-name-internal file-exists-p)
  minibuffer-complete()
  funcall-interactively(minibuffer-complete)
  call-interactively(minibuffer-complete nil nil)
  command-execute(minibuffer-complete)
  read-from-minibuffer("Find file: " "~/" (keymap (keymap (32)) keymap (10
. minibuffer-complete-and-exit) (13 . minibuffer-complete-and-exit) keymap
(menu-bar keymap (minibuf "Minibuf" keymap (tab menu-item "Complete"
minibuffer-complete :help "Complete as far as possible") (space menu-item
"Complete Word" minibuffer-complete-word :help "Complete at most one word")
(63 menu-item "List Completions" minibuffer-completion-help :help "Display
all possible completions") "Minibuf")) (27 keymap (118 .
switch-to-completions)) (prior . switch-to-completions) (63 .
minibuffer-completion-help) (32 . minibuffer-complete-word) (9 .
minibuffer-complete) keymap (menu-bar keymap (minibuf "Minibuf" keymap
(previous menu-item "Previous History Item" previous-history-element :help
"Put previous minibuffer history element in the minibuffer") (next
menu-item "Next History Item" next-history-element :help "Put next
minibuffer history element in the minibuffer") (isearch-backward menu-item
"Isearch History Backward" isearch-backward :help "Incrementally search
minibuffer history backward") (isearch-forward menu-item "Isearch History
Forward" isearch-forward :help "Incrementally search minibuffer history
forward") (return menu-item "Enter" exit-minibuffer :key-sequence "\015"
:help "Terminate input and exit minibuffer") (quit menu-item "Quit"
abort-recursive-edit :help "Abort input and exit minibuffer") "Minibuf"))
(10 . exit-minibuffer) (13 . exit-minibuffer) (7 . abort-recursive-edit)
(C-tab . file-cache-minibuffer-complete) (9 . self-insert-command)
(XF86Back . previous-history-element) (up .
previous-line-or-history-element) (prior . previous-history-element)
(XF86Forward . next-history-element) (down . next-line-or-history-element)
(next . next-history-element) (27 keymap (114 .
previous-matching-history-element) (115 . next-matching-history-element)
(112 . previous-history-element) (110 . next-history-element))) nil
file-name-history "~/" nil)
  completing-read-default("Find file: " read-file-name-internal
file-exists-p confirm-after-completion "~/" file-name-history "~/" nil)
  completing-read("Find file: " read-file-name-internal file-exists-p
confirm-after-completion "~/" file-name-history "~/")
  read-file-name-default("Find file: " nil "~/" confirm-after-completion
nil nil)
  read-file-name("Find file: " nil "~/" confirm-after-completion)
  find-file-read-args("Find file: " confirm-after-completion)
  byte-code("\300\301\302 \"\207" [find-file-read-args "Find file: "
confirm-nonexistent-file-or-buffer] 3)
  call-interactively(find-file nil nil)
  command-execute(find-file)


On Wed, Dec 5, 2018 at 2:38 AM Michael Albinus <michael.albinus@gmx.de>
wrote:

> Andreas Schwab <schwab@linux-m68k.org> writes:
>
> > On Dez 04 2018, David Hull <david.hull@openx.com> wrote:
> >
> >> Filename completion does not work with tramp's "simplified" syntax.
> >>
> >>   (load-library "tramp")
> >>   (tramp-change syntax 'simplified)
> >>
> >> Now if I run find-file and type "//cos6:src/ss" and then TAB I get the
> >> error:
> >>
> >>   completion--some: Wrong type argument: stringp, ""
> >
> > This is fixed by commit b8b42c2315.
>
> Indeed, you've backported this fix to the emacs-26 branch. The bug
> report tells us
>
> --8<---------------cut here---------------start------------->8---
> In GNU Emacs 26.1.90 (build 1, x86_64-apple-darwin18.2.0, NS
> appkit-1671.10 Version 10.14.1 (Build 18B75))
>  of 2018-12-03 built on mbp-109-op-04
> Repository revision: 8d7e58ce9f389d77323e0237c22c4e13cb68b8e7
> --8<---------------cut here---------------end--------------->8---
>
> Hmm, a git commit 8d7e58ce9f389d77323e0237c22c4e13cb68b8e7 does not
> exist in emacs-26 or master branches.
>
> > Andreas.
>
> Best regards, Michael.
>


-- 
David Hull

[-- Attachment #2: Type: text/html, Size: 8138 bytes --]

bug#33619: 26.1.90; Tramp "simplified" syntax completion problem

[David Hull]

[-- Attachment #1: Type: text/plain, Size: 6711 bytes --]

I can confirm that when commit 8d7e58ce9f389d77323e0237c22c4e is applied to
emacs-26.1.90 that my problem no longer occurs.

http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-26.1.90&id=b8b42c23151298565e4354b38d7060e91465daed




On Wed, Dec 5, 2018 at 9:13 AM David Hull <david.hull@openx.com> wrote:

> My emacs was built from a tarball I downloaded from
> http://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-26.1.90.tar.gz.
> I believe this is commit 7851ae8b443c62a41ea4f4440512aa56cc87b9b7. It looks
> like this does not have the change made in commit
> 8d7e58ce9f389d77323e0237c22c4e.
> Here is the backtrace from my current build as requested. I will also try
> applying the fix from 8d7e58ce9f389d77323e0237c22c4e and test again.
>
> I ran "emacs -Q -l tramp", then in the *scratch* buffer:
>
> (emacs-version)
> "GNU Emacs 26.1.90 (build 1, x86_64-apple-darwin18.2.0, NS appkit-1671.10
> Version 10.14.1 (Build 18B75))\n of 2018-12-03"
> (tramp-change-syntax 'simplified)
> simplified
> (setq debug-on-error t)
> t
>
> Then when I typed (from "view-lossage"):
>
>  C-x C-f [find-file]
>  / [self-insert-command]
>  c [self-insert-command]
>  o [self-insert-command]
>  s [self-insert-command]
>  6 [self-insert-command]
>  : [self-insert-command]
>  s [self-insert-command]
>  r [self-insert-command]
>  c [self-insert-command]
>  / [self-insert-command]
>  s [self-insert-command]
>  s [self-insert-command]
>  <tab> [minibuffer-complete]
>
> I got the error:
>
> Debugger entered--Lisp error: (wrong-type-argument stringp "")
>   signal(wrong-type-argument (stringp ""))
>   completion--some(#f(compiled-function (style) #<bytecode 0x40e7eafd>)
> (basic partial-completion emacs22))
>   completion--nth-completion(1 "~//cos6:src/ss" read-file-name-internal
> file-exists-p 14 (metadata (category . file) (completion--unquote-requote .
> t)))
>   completion-try-completion("~//cos6:src/ss" read-file-name-internal
> file-exists-p 14 (metadata (category . file) (completion--unquote-requote .
> t)))
>   completion--do-completion(12 26)
>   completion--in-region-1(12 26)
>   #f(compiled-function (start end collection predicate) #<bytecode
> 0x400c2e6b>)(12 26 read-file-name-internal file-exists-p)
>   apply(#f(compiled-function (start end collection predicate) #<bytecode
> 0x400c2e6b>) (12 26 read-file-name-internal file-exists-p))
>   #f(compiled-function (funs global args) #<bytecode 0x40e6bd1d>)(nil nil
> (12 26 read-file-name-internal file-exists-p))
>   completion--in-region(12 26 read-file-name-internal file-exists-p)
>   completion-in-region(12 26 read-file-name-internal file-exists-p)
>   minibuffer-complete()
>   funcall-interactively(minibuffer-complete)
>   call-interactively(minibuffer-complete nil nil)
>   command-execute(minibuffer-complete)
>   read-from-minibuffer("Find file: " "~/" (keymap (keymap (32)) keymap (10
> . minibuffer-complete-and-exit) (13 . minibuffer-complete-and-exit) keymap
> (menu-bar keymap (minibuf "Minibuf" keymap (tab menu-item "Complete"
> minibuffer-complete :help "Complete as far as possible") (space menu-item
> "Complete Word" minibuffer-complete-word :help "Complete at most one word")
> (63 menu-item "List Completions" minibuffer-completion-help :help "Display
> all possible completions") "Minibuf")) (27 keymap (118 .
> switch-to-completions)) (prior . switch-to-completions) (63 .
> minibuffer-completion-help) (32 . minibuffer-complete-word) (9 .
> minibuffer-complete) keymap (menu-bar keymap (minibuf "Minibuf" keymap
> (previous menu-item "Previous History Item" previous-history-element :help
> "Put previous minibuffer history element in the minibuffer") (next
> menu-item "Next History Item" next-history-element :help "Put next
> minibuffer history element in the minibuffer") (isearch-backward menu-item
> "Isearch History Backward" isearch-backward :help "Incrementally search
> minibuffer history backward") (isearch-forward menu-item "Isearch History
> Forward" isearch-forward :help "Incrementally search minibuffer history
> forward") (return menu-item "Enter" exit-minibuffer :key-sequence "\015"
> :help "Terminate input and exit minibuffer") (quit menu-item "Quit"
> abort-recursive-edit :help "Abort input and exit minibuffer") "Minibuf"))
> (10 . exit-minibuffer) (13 . exit-minibuffer) (7 . abort-recursive-edit)
> (C-tab . file-cache-minibuffer-complete) (9 . self-insert-command)
> (XF86Back . previous-history-element) (up .
> previous-line-or-history-element) (prior . previous-history-element)
> (XF86Forward . next-history-element) (down . next-line-or-history-element)
> (next . next-history-element) (27 keymap (114 .
> previous-matching-history-element) (115 . next-matching-history-element)
> (112 . previous-history-element) (110 . next-history-element))) nil
> file-name-history "~/" nil)
>   completing-read-default("Find file: " read-file-name-internal
> file-exists-p confirm-after-completion "~/" file-name-history "~/" nil)
>   completing-read("Find file: " read-file-name-internal file-exists-p
> confirm-after-completion "~/" file-name-history "~/")
>   read-file-name-default("Find file: " nil "~/" confirm-after-completion
> nil nil)
>   read-file-name("Find file: " nil "~/" confirm-after-completion)
>   find-file-read-args("Find file: " confirm-after-completion)
>   byte-code("\300\301\302 \"\207" [find-file-read-args "Find file: "
> confirm-nonexistent-file-or-buffer] 3)
>   call-interactively(find-file nil nil)
>   command-execute(find-file)
>
>
> On Wed, Dec 5, 2018 at 2:38 AM Michael Albinus <michael.albinus@gmx.de>
> wrote:
>
>> Andreas Schwab <schwab@linux-m68k.org> writes:
>>
>> > On Dez 04 2018, David Hull <david.hull@openx.com> wrote:
>> >
>> >> Filename completion does not work with tramp's "simplified" syntax.
>> >>
>> >>   (load-library "tramp")
>> >>   (tramp-change syntax 'simplified)
>> >>
>> >> Now if I run find-file and type "//cos6:src/ss" and then TAB I get the
>> >> error:
>> >>
>> >>   completion--some: Wrong type argument: stringp, ""
>> >
>> > This is fixed by commit b8b42c2315.
>>
>> Indeed, you've backported this fix to the emacs-26 branch. The bug
>> report tells us
>>
>> --8<---------------cut here---------------start------------->8---
>> In GNU Emacs 26.1.90 (build 1, x86_64-apple-darwin18.2.0, NS
>> appkit-1671.10 Version 10.14.1 (Build 18B75))
>>  of 2018-12-03 built on mbp-109-op-04
>> Repository revision: 8d7e58ce9f389d77323e0237c22c4e13cb68b8e7
>> --8<---------------cut here---------------end--------------->8---
>>
>> Hmm, a git commit 8d7e58ce9f389d77323e0237c22c4e13cb68b8e7 does not
>> exist in emacs-26 or master branches.
>>
>> > Andreas.
>>
>> Best regards, Michael.
>>
>
>
> --
> David Hull
>


-- 
David Hull

[-- Attachment #2: Type: text/html, Size: 9117 bytes --]

bug#33619: 26.1.90; Tramp "simplified" syntax completion problem

[Michael Albinus]

Version: 26.2

David Hull <david.hull@openx.com> writes:

Hi David,

> I can confirm that when commit 8d7e58ce9f389d77323e0237c22c4e is
> applied to emacs-26.1.90 that my problem no longer occurs.

Thanks for the feedback. So I'm closing the bug, you'll get the solution
with the next Emacs 26.2 pretest.

>     David Hull

Best regards, Michael.

bug#33619: 26.1.90; Tramp "simplified" syntax completion problem

[David Hull]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

Thank you for all your help.

On Wed, Dec 5, 2018 at 9:54 AM Michael Albinus <michael.albinus@gmx.de>
wrote:

> Version: 26.2
>
> David Hull <david.hull@openx.com> writes:
>
> Hi David,
>
> > I can confirm that when commit 8d7e58ce9f389d77323e0237c22c4e is
> > applied to emacs-26.1.90 that my problem no longer occurs.
>
> Thanks for the feedback. So I'm closing the bug, you'll get the solution
> with the next Emacs 26.2 pretest.
>
> >     David Hull
>
> Best regards, Michael.
>


-- 
David Hull

[-- Attachment #2: Type: text/html, Size: 1015 bytes --]