From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#36317: [PATCH v2] Allow underscore in defun-prompt-regex names for sh-script Date: Thu, 27 Jun 2019 20:15:17 -0400 Message-ID: <875zoq7ega.fsf@gmail.com> References: <20190620230122.22553-1-ola.nilsson@gmail.com> <20190623210025.8366-1-ola.nilsson@gmail.com> <85y31p69y7.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="42832"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) Cc: 36317@debbugs.gnu.org To: Ola Nilsson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 28 02:16:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgeYw-000Aye-5a for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Jun 2019 02:16:22 +0200 Original-Received: from localhost ([::1]:55350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgeYv-0002bG-2T for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2019 20:16:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33971) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgeYe-0002az-7t for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 20:16:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgeYc-0005fL-IC for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 20:16:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54766) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgeYb-0005ej-UA for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 20:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hgeYb-00062q-Pl for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 20:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jun 2019 00:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36317 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36317-submit@debbugs.gnu.org id=B36317.156168092723182 (code B ref 36317); Fri, 28 Jun 2019 00:16:01 +0000 Original-Received: (at 36317) by debbugs.gnu.org; 28 Jun 2019 00:15:27 +0000 Original-Received: from localhost ([127.0.0.1]:40077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgeY3-00061l-Ab for submit@debbugs.gnu.org; Thu, 27 Jun 2019 20:15:27 -0400 Original-Received: from mail-io1-f42.google.com ([209.85.166.42]:34116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgeY0-00061R-R6; Thu, 27 Jun 2019 20:15:25 -0400 Original-Received: by mail-io1-f42.google.com with SMTP id k8so8812760iot.1; Thu, 27 Jun 2019 17:15:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=9Ck68x1m1ZZvkqSO25kBiyv1zeh77YlzousDhiMapIc=; b=GnJ8fVsez6HuO6c6Y3J2yYHh3BwOe7UNZlVozT50ABB2gRc6YMfpEzmB8slAaSkT4o wdK23/gFjjYpknP6zp1aa9cv/h3iA7cEuu540yjP63o9QbTtvdrSUlqmQ3L++VaBBiNr ZGKmgvb9WMRZWhfImiaruY2r9B7xF5FD10q9PyrXyykbEEiH5eEjR0T0Bn6ox8NkbTio 4icmo4i1q5yHlZuP8b6RK3pWGceHRayN27UYWfVlQ2l+RcIkiLBuhi80SyZvyt1SS2Ux dyMWWLlRq2KVnQ+Nv/xERw+2Tw9iVxC2T5jaERsc0lWPOaWC6oRYL5NChJgmYcJlatql nTGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=9Ck68x1m1ZZvkqSO25kBiyv1zeh77YlzousDhiMapIc=; b=Z1/auyixRQEipcGRMrtmutvpcdPlLcQFRFuhInO7lMWLbxRAdVVU5jGtFt2ytSNcLb DD1awDPCZ7DLBV2W8fjr1XASck8hyXzySFG8nhc6jiiS3ou3uo5Fj4X5N2omnSPKGfE1 9iDpE56liPHtKshmT9WLxM4N43o7gMH/dJlssAREE2UhGejRnR7sVn6NOvlrfWx/i+Uj nW0fboVRnApMMq7nNyeXWHAk8OO7On2nOWQkCHRggbNn0sQqrPBWg1WvLjeazoItHyIZ SXtiRwxBFVAr/znNKfiEnDFGOwv1hLU9uz5rvJOnw6VegqbGJJNkDigCMq2k9KNIsnS9 uvMA== X-Gm-Message-State: APjAAAURNBgBct1Wdzb3mlBiW7OjnNRbIle7AaYNGydfDw7ECzHuGAzS 0ix3q/WUHHt75IFxcsMeTp1KUV4A X-Google-Smtp-Source: APXvYqxIr7aUdZJAYwgBH4u4GZGCrTd9NXAth+uUkaJLu0CGPfb7/TGdxVW8NtMaCEPcDBU73uxxCA== X-Received: by 2002:a6b:3883:: with SMTP id f125mr7826549ioa.109.1561680919063; Thu, 27 Jun 2019 17:15:19 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id r24sm507823ioc.76.2019.06.27.17.15.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Jun 2019 17:15:18 -0700 (PDT) In-Reply-To: (Ola Nilsson's message of "Wed, 26 Jun 2019 22:58:06 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161672 Archived-At: tags 36317 fixed close 36317 27.1 quit Ola Nilsson writes: > sh-script.el does not have a centralized way of dealing with function names. > > * imenu (the problem in Bug#21477) does not use defun-prompt-regexp, > but rather its > own regexp found in sh-imenu-generic-expression. Funnily enough > those function > names _do_ follow the posix standard (letters, digits, underscore, > must not start with > a digit). > * sh-current-defun-name also has its own regexps, matching those of > sh-imenu-generic-expression. > * sh-font-lock-keyword-var uses "\\sw+" which is a lot less strict with what > characters can be included. > * sh-completion-at-point-function uses "[[:alnum:]_]" to skip to > beginning and end > of a function name. > > I assume there are some other cases that I missed. Darn, that's a lot more complicated than I was hoping. > As far as I can tell from a quick search of shell manuals and net > questions most shells stick to the posix spec. Bash is the exception > and seems to be very forgiving at least as long as you use the > 'function name() {...}' format. > > So I guess it boils down to how allowing we want to be. IMO, allowing more things makes sense, but I've just gone ahead and push your patch v2 to master, since it's clearly a step in the right direction. Cleaning up the rest of the mess would be nice too, but it looks like a lot of untangling to be done. fa3af359df 2019-06-27T20:02:54-04:00 "Allow underscore in defun-prompt-regex names for sh-script" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=fa3af359df8754423a197682d31245ad88c02033