unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: "積丹尼 Dan Jacobson" <jidanni@jidanni.org>
Cc: 35421@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#35421: Also bind left image rotation key
Date: Wed, 17 Jul 2019 00:52:59 +0100	[thread overview]
Message-ID: <875zo1y1t0.fsf@tcd.ie> (raw)
In-Reply-To: <874l3vuube.5.fsf@jidanni.org> ("積丹尼 Dan Jacobson"'s message of "Tue, 09 Jul 2019 23:00:21 +0800")

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

> args
> 1,2,3=
> 90,180,270
> or something like that.

Image viewers like gThumb provide buttons for rotations in steps of 90
degrees, and Emacs isn't even an image viewer, so there's no need to
complicate and restrict (w.r.t. future changes) the command's calling
convention like that.

Instead, the proposed patch[1] makes the simplest possible change to
support counter-clockwise rotations in one step, rather than three.  In
addition, it makes image-rotate accept arbitrary rotation angles when
called from Lisp, so you can use it to easily write your own
image-rotating command, with your preferred calling convention.

[1]: https://debbugs.gnu.org/35421#31

-- 
Basil





  reply	other threads:[~2019-07-16 23:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24 23:23 bug#35421: Also bind left image rotation key 積丹尼 Dan Jacobson
2019-07-09 14:04 ` Lars Ingebrigtsen
2019-07-09 14:12   ` 積丹尼 Dan Jacobson
2019-07-09 14:13   ` 積丹尼 Dan Jacobson
2019-07-09 14:54   ` Basil L. Contovounesios
2019-07-09 15:00     ` 積丹尼 Dan Jacobson
2019-07-16 23:52       ` Basil L. Contovounesios [this message]
2019-07-16 23:45     ` Basil L. Contovounesios
2019-07-17 11:03       ` Lars Ingebrigtsen
2019-07-20 15:06         ` Basil L. Contovounesios
2019-07-19  0:53       ` 積丹尼 Dan Jacobson
2019-07-20 15:12         ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zo1y1t0.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=35421@debbugs.gnu.org \
    --cc=jidanni@jidanni.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).