unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 35421@debbugs.gnu.org, "積丹尼 Dan Jacobson" <jidanni@jidanni.org>
Subject: bug#35421: Also bind left image rotation key
Date: Wed, 17 Jul 2019 13:03:40 +0200	[thread overview]
Message-ID: <875zo0apo3.fsf@mouse.gnus.org> (raw)
In-Reply-To: <87sgr5y263.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 17 Jul 2019 00:45:08 +0100")

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> I think this is a good solution for several reasons:
>
> 1. It does not require a new key binding, and it does not overly
>    complicate the calling convention of the current key binding.
>
> 2. It turns image-rotate into a general image-rotating subroutine,
>    which users and library authors alike can reuse.
>
> 2.1. It does not limit rotations of imagemagick images to multiples of
>      90 degrees.
>
> and I don't see any drawbacks, so I would like to push this to master,
> subject to comments/objections.

Looks good to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2019-07-17 11:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24 23:23 bug#35421: Also bind left image rotation key 積丹尼 Dan Jacobson
2019-07-09 14:04 ` Lars Ingebrigtsen
2019-07-09 14:12   ` 積丹尼 Dan Jacobson
2019-07-09 14:13   ` 積丹尼 Dan Jacobson
2019-07-09 14:54   ` Basil L. Contovounesios
2019-07-09 15:00     ` 積丹尼 Dan Jacobson
2019-07-16 23:52       ` Basil L. Contovounesios
2019-07-16 23:45     ` Basil L. Contovounesios
2019-07-17 11:03       ` Lars Ingebrigtsen [this message]
2019-07-20 15:06         ` Basil L. Contovounesios
2019-07-19  0:53       ` 積丹尼 Dan Jacobson
2019-07-20 15:12         ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zo0apo3.fsf@mouse.gnus.org \
    --to=larsi@gnus.org \
    --cc=35421@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=jidanni@jidanni.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).