unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Alexander Shukaev <emacs@Alexander.Shukaev.name>
Cc: 25189@debbugs.gnu.org
Subject: bug#25189: Use `current-global-map' in `comint-insert-input'
Date: Sat, 27 Jul 2019 13:29:17 +0200	[thread overview]
Message-ID: <875znnk96a.fsf@mouse.gnus.org> (raw)
In-Reply-To: <7a0f388c-3678-cf59-5da6-11c532f4fcdd@Alexander.Shukaev.name> (Alexander Shukaev's message of "Tue, 13 Dec 2016 01:36:08 +0100")

Alexander Shukaev <emacs@Alexander.Shukaev.name> writes:

> I think according to Emacs documentation it's more correct to change the
>
> (lookup-key global-map (vector last-key))
>
> form to the
>
> (lookup-key (current-global-map) (vector last-key))
>
> form.

(I'm going through older Emacs bug reports that have received no
response.)

Looking at the manual section in "Controlling Active Maps", there
doesn't seem to be anything to discourage using `global-map' directly
there.  I've grepped through the sources, though, and `global-map' is
used all over the place (while `current-global-map' is used less).

So this doesn't seem like something to be fixed, and I'm closing this
bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2019-07-27 11:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-13  0:36 bug#25189: Use `current-global-map' in `comint-insert-input' Alexander Shukaev
2019-07-27 11:29 ` Lars Ingebrigtsen [this message]
2019-12-16  1:58   ` Alexander Shukaev
     [not found]   ` <45ae521c-6f37-292e-c169-9ed591cb0504@Alexander.Shukaev.name>
2019-12-24 16:25     ` Lars Ingebrigtsen
2019-12-25  9:59       ` Alexander Shukaev
2019-12-25 21:39         ` Lars Ingebrigtsen
2019-12-26  0:32           ` Alexander Shukaev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875znnk96a.fsf@mouse.gnus.org \
    --to=larsi@gnus.org \
    --cc=25189@debbugs.gnu.org \
    --cc=emacs@Alexander.Shukaev.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).