From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#24649: 24.5; Why no standard error for "Trailing garbage following expression"? Date: Sat, 27 Jul 2019 16:11:52 +0200 Message-ID: <875znnh8if.fsf@mouse.gnus.org> References: <58b6fb05-499d-4406-9bac-9c0889a588b8@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="173609"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 24649@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 27 16:12:08 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrNQe-000j0b-Iu for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jul 2019 16:12:08 +0200 Original-Received: from localhost ([::1]:45932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrNQc-0006cp-SP for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jul 2019 10:12:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43257) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrNQZ-0006cW-K0 for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 10:12:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrNQY-000154-KO for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 10:12:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36267) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hrNQY-00014z-HZ for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 10:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hrNQY-00025I-AA for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 10:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jul 2019 14:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24649 X-GNU-PR-Package: emacs Original-Received: via spool by 24649-submit@debbugs.gnu.org id=B24649.15642367187997 (code B ref 24649); Sat, 27 Jul 2019 14:12:02 +0000 Original-Received: (at 24649) by debbugs.gnu.org; 27 Jul 2019 14:11:58 +0000 Original-Received: from localhost ([127.0.0.1]:45087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrNQU-00024v-Jo for submit@debbugs.gnu.org; Sat, 27 Jul 2019 10:11:58 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:39412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrNQT-00024l-FN for 24649@debbugs.gnu.org; Sat, 27 Jul 2019 10:11:58 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrNQP-0001Ru-Bx; Sat, 27 Jul 2019 16:11:55 +0200 In-Reply-To: <58b6fb05-499d-4406-9bac-9c0889a588b8@default> (Drew Adams's message of "Sun, 9 Oct 2016 18:03:04 +0000 (UTC)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163871 Archived-At: Drew Adams writes: > Shouldn't this error be a standard error? If not a new standard error, > shouldn't it at least use one of the existing standard errors, such as > `scan-error' or `invalid-read-syntax'? > > Otherwise, how to easily handle this error (e.g., to tell the user to > correct the input being read and then read again)? Makes sense to me. I'm not sure what signal to use, though -- anybody got an idea? Tentative patch: diff --git a/src/minibuf.c b/src/minibuf.c index 14a0dbe762..f6cf47f1f2 100644 --- a/src/minibuf.c +++ b/src/minibuf.c @@ -169,7 +169,8 @@ string_to_object (Lisp_Object val, Lisp_Object defalt) { int c = SREF (val, i); if (c != ' ' && c != '\t' && c != '\n') - error ("Trailing garbage following expression"); + xsignal1 (Qinvalid_read_syntax, + build_string ("Trailing garbage following expression")); } } -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no