From: Lars Ingebrigtsen <larsi@gnus.org>
To: Erik Hetzner <erik.hetzner@ucop.edu>
Cc: 14983@debbugs.gnu.org, Andreas Schwab <schwab@suse.de>
Subject: bug#14983: 24.3.50; url-http-end-of-document-sentinel does not work with https
Date: Tue, 24 Sep 2019 09:58:42 +0200 [thread overview]
Message-ID: <875zli2ki5.fsf@gnus.org> (raw)
In-Reply-To: <20130730141910.2167122AC01@mailgate.ucop.edu> (Erik Hetzner's message of "Tue, 30 Jul 2013 07:20:01 -0700")
Erik Hetzner <erik.hetzner@ucop.edu> writes:
> - (url-http url-current-object url-callback-function
> - url-callback-arguments (current-buffer)))))
> + (if (string= "https" (url-type url-current-object))
> + (url-https url-current-object url-callback-function
> + url-callback-arguments (current-buffer))
> + (url-http url-current-object url-callback-function
> + url-callback-arguments (current-buffer))))))
The code has changed in the meantime, so I applied the following patch
instead:
diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
index bfc106c2a5..a6963cef70 100644
--- a/lisp/url/url-http.el
+++ b/lisp/url/url-http.el
@@ -1024,7 +1024,9 @@ url-http-end-of-document-sentinel
(setq url-using-proxy
(url-generic-parse-url url-using-proxy)))
(url-http url-current-object url-callback-function
- url-callback-arguments (current-buffer)))))
+ url-callback-arguments (current-buffer)
+ (and (string= "https" (url-type url-current-object))
+ 'tls)))))
((url-http-parse-headers)
(url-http-activate-callback))))))
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-09-24 7:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 2:29 bug#14983: 24.3.50; url-http-end-of-document-sentinel does not work with https Erik Hetzner
2013-07-30 8:50 ` Andreas Schwab
2013-07-30 14:01 ` Erik Hetzner
2013-07-30 14:20 ` Erik Hetzner
2015-12-25 21:03 ` Lars Ingebrigtsen
2019-05-20 18:56 ` Noam Postavsky
2019-09-24 7:58 ` Lars Ingebrigtsen [this message]
2013-07-30 14:20 ` Erik Hetzner
2019-06-17 2:58 ` Noam Postavsky
2019-06-20 1:20 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zli2ki5.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=14983@debbugs.gnu.org \
--cc=erik.hetzner@ucop.edu \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).