From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#37806: 27.0.50; Need to "extend" face-remap.el Date: Fri, 18 Oct 2019 11:14:09 +0200 Message-ID: <875zkmmn4u.fsf@gmx.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="33741"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: 37806@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 18 11:15:43 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iLOMH-0008cA-PK for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Oct 2019 11:15:41 +0200 Original-Received: from localhost ([::1]:36916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLOMG-0006rS-43 for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Oct 2019 05:15:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44734) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLOLg-0006oZ-7S for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 05:15:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLOLf-0007TY-0A for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 05:15:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40549) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iLOLe-0007TS-Q1 for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 05:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iLOLe-0001Kp-JD for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 05:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Oct 2019 09:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37806 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15713900635021 (code B ref -1); Fri, 18 Oct 2019 09:15:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Oct 2019 09:14:23 +0000 Original-Received: from localhost ([127.0.0.1]:49368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLOL0-0001Iv-RL for submit@debbugs.gnu.org; Fri, 18 Oct 2019 05:14:23 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:51929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLOKy-0001In-ES for submit@debbugs.gnu.org; Fri, 18 Oct 2019 05:14:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44605) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLOKx-0006Oj-6b for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 05:14:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLOKw-00079P-0r for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 05:14:19 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:45907) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iLOKv-00074D-JM for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 05:14:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1571390051; bh=XCCWewhCCAgRNxREXm0T3S58HdbGlRdS1YsSDTBedJM=; h=X-UI-Sender-Class:From:To:Subject:Date; b=eFpZKoBzUQhb6eGehuHk8wuQkEZuNkDve8Uj+k0C44ztgXj1QW1B6yDEMudrkg5zB xs5V6IQCKYglJgznyyA1SI/rVTOPL0rRiyBH6REMy1bVMuV553sC8M1EQjG+2Gpxh1 EjlH/lsqO+QanbV542kZzbw1ok6RXKcf4It6Aq8M= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobe-lfs84 ([178.6.146.152]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N2E1M-1huQ5U3SN4-013ajq for ; Fri, 18 Oct 2019 11:14:10 +0200 X-Provags-ID: V03:K1:eq1PoRI2XXypXXPFymx0R+l682iphpTLyAARWR0p5TIH59xSumT ikVZbnHu3fsMJdDnpBnigzVf06GXHFBlVO3bFNVXkxkjitDLjjuqKAjpP08/ZU4Hm1NeeT7 Au1nNfhNbti84mHc3O6x/yjs15hZzCtYpfAAysZka34B/gXMXJuOGXcY3mTqyJzK3hlRN0K A6nrSbHmm09+5CsfvpvcA== X-UI-Out-Filterresults: notjunk:1;V03:K0:T0pFg4fVNrk=:lj6tpRnkeHs5EE0dqvZsMM eUnWPJHDIw3an7eqRM2M5ErDQxVPrag2T2xog4mXJOHTCIMkNLu3RlMXI2aGspSJQcsEKxF7k RPK4gIhyMdWEF7VAZ5M3OZtJpFjhBGNNr4KxY23qYrnKJE/Ym0FV9VStfhZfaCd7VwK/XVCcl hqJ3fEGUkBPOXsJSsHde+icZSP75SvTPBKvI0I6GRql+48sz3/qUMXC+QwJIG1oO0QPMrs4ZA sZxJ7WrPB3l82+m1WsOs26EYsUIicVdy+SGt8sh/arRjHj9/qWteHrbsdGsCrKkKCUbJAkTX/ euZxNFi+EA/UnNGeLlRsh8TzRYfRuuEaXXbmgmDHasHcwCeP7XB5GuUyFlLj11P7aICi7YAMD wBTZkXAP9yV6C/oE8KoY0Fc1JNaxxBdtK4j2ZwKZTHvTz8y1TdpRb0XrdH1cffOFuDuBd7sbA +qIwB7W8f+bs0q8OxVpIc3sfKPCOYzxFnzEbwCtOVs5ULMX9nUEvqXLsfzct4CcZIFBmSdp/I PCWyTqrR8pPDWwnK4Iiaj69xUkrpn8NK9yzH0FjUFIhSywvKpDKsdP30r4KkRZA8a7YlhdUbt CssZG00+91QVYTuQ4PChk9b/AJTwSya8ll53DJxvCCem3mPZA0kePt1MdVafO0rcr4Nfsh5mM otUtzVUtjW/H1ufIScVXdb39fzsGgwcqdxt21ZaK5sbfOgoFtcqUx6T759G5Rv3qL9jckl4H7 4IHBDFocMgFgzi16AVUpiSXcgV/+WanMpcg4JRLCOIAw1HvtyqF4nme36CZYPM3IPESIWuGL X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169653 Archived-At: --=-=-= Content-Type: text/plain 0. emacs -Q 1. C-x C-+ (i.e. M-x text-scale-adjust) 2. M-x variable-pitch-mode or M-x buffer-face-mode => Args out of range: [nil :family :foundry :swidth :height :weight :slant :underline :inverse :foreground ...], 19 The error happens because the vector of face attributes defined in face-remap.el is missing the recently added :extend attribute, so it is too short. This also breaks the MELPA package charmap.el (that's where I hit the error). The patch below fixes this, though perhaps now would be a good time to do what the comment above the definition of the vector says: "This variable should probably be defined in C code where the actual definitions are available." Or is this simple fix good enough? (The vector is also missing the :distant-foreground attribute, so the patch adds that as well. This absence happened to be innocuous because the first element of the vector is nil, in order to make the attribute indices match those of the enum lface_attribute_index defined in dispextern.h, so the vector was long enough; but after the addition of the :extend attribute, it wasn't anymore (only the indices of the vector are used in face-remap.el).) In GNU Emacs 27.0.50 (build 17, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2019-10-18 built on strobe-lfs84 Repository revision: 2d13a3f68d4724af52e47675bedf60709c7b5171 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 System Description: Linux From Scratch --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=face-remap.diff Content-Description: face-remap patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/face-remap.el b/lisp/face-remap.el index 5cdecb92ee..8e565264fe 100644 =2D-- a/lisp/face-remap.el +++ b/lisp/face-remap.el @@ -69,7 +69,7 @@ internal-lisp-face-attributes [nil :family :foundry :swidth :height :weight :slant :underline :inverse :foreground :background :stipple :overline :strike :box - :font :inherit :fontset :vector]) + :font :inherit :fontset :distant :extend :vector]) (defun face-attrs-more-relative-p (attrs1 attrs2) "Return true if ATTRS1 contains a greater number of relative --=-=-=--