From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#38248: help-follow-symbol silent when no symbol was found Date: Thu, 21 Nov 2019 16:12:03 +0100 Message-ID: <875zjdxnzw.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="188780"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 38248@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 21 16:13:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXo8u-000myQ-6s for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 16:13:12 +0100 Original-Received: from localhost ([::1]:41730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXo8t-000614-0R for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 10:13:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47938) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXo8l-0005yy-Pn for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 10:13:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXo8k-0002N4-P7 for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 10:13:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44387) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXo8k-0002N0-Lr for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 10:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXo8k-0002DR-CV for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 10:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Nov 2019 15:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38248 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38248-submit@debbugs.gnu.org id=B38248.15743491358435 (code B ref 38248); Thu, 21 Nov 2019 15:13:02 +0000 Original-Received: (at 38248) by debbugs.gnu.org; 21 Nov 2019 15:12:15 +0000 Original-Received: from localhost ([127.0.0.1]:53205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXo7z-0002Bx-5D for submit@debbugs.gnu.org; Thu, 21 Nov 2019 10:12:15 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:32846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXo7w-0002Bi-9U for 38248@debbugs.gnu.org; Thu, 21 Nov 2019 10:12:13 -0500 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iXo7o-0006KZ-Bl; Thu, 21 Nov 2019 16:12:06 +0100 In-Reply-To: (Juanma Barranquero's message of "Sun, 17 Nov 2019 20:40:33 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172139 Archived-At: Juanma Barranquero writes: > That's not just inconsistent, but a bit disconcerting, as sometimes > following a symbol can be slow. In my build, it takes a second or more > to show the symbol documentation, so when there's no symbol I stand > waiting for something to happen for a couple of seconds. > > The following patch fixes that. The only reason against I can think of > is when `help-follow-symbol' is called from elisp, because it will now > signal an error. However, at least in the Emacs sources > help-follow-symbol is never called from elisp, just as a keybinding or > menu entry. Adding an error-out here I think should be OK. I googled a bit and couldn't see anything out-of-tree that uses that command as a function. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no