From: Sean Whitton <spwhitton@spwhitton.name>
To: Drew Adams <drew.adams@oracle.com>, 42210@debbugs.gnu.org
Cc: dgutov@yandex.ru, juri@linkov.net
Subject: bug#42210: Add -other-window variants of project-prefix-map commands
Date: Sun, 05 Jul 2020 13:25:13 -0700 [thread overview]
Message-ID: <875zb1hfpy.fsf@iris.silentflame.com> (raw)
In-Reply-To: <e29d529e-d26b-43a6-99e3-dd8bba15ee3b@default>
Hello,
On Sun 05 Jul 2020 at 11:35AM -07, Drew Adams wrote:
> 1. I disagree with calling the macro `define-other-window-command'.
>
> My disagreement is this: Defining an other-window command
> should do just that. It should not define a command that
> only "prefers" to display in another window. It should
> define a command that actually displays in another window.
>
> And your doc string in fact says the latter, though the
> behavior is, I guess, only the former. Please consider
> renaming the macro and fixing the doc string, to make clear
> that it's NOT other-window but only maybe-other-window.
Hmm, but doesn't pop-to-buffer-other-window also only prefer to use
another window, and ultimately defers to the display-buffer-alist
machinery?
> 2. Why "resultant buffer". What does the buffer result
> from? It's about whatever FUNCTION displays, no?
Please feel free to suggest alternative phrasing that will be short
enough to fit in one line, which I understand to be required.
> 3. Presumably FUNCTION must be a _command_. If so,
> the arg should be called COMMAND, and the doc adjusted
> accordingly.
No, it can just be a function too.
--
Sean Whitton
next prev parent reply other threads:[~2020-07-05 20:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87blkw5cd3.fsf@iris.silentflame.com>
2020-07-05 6:13 ` bug#42210: Add -other-window variants of project-prefix-map commands Sean Whitton
2020-07-05 14:41 ` Eli Zaretskii
2020-07-05 18:35 ` Drew Adams
2020-07-05 20:25 ` Sean Whitton [this message]
2020-07-06 0:00 ` Drew Adams
2020-07-06 0:19 ` Juri Linkov
2020-07-06 1:58 ` Sean Whitton
2020-07-06 22:59 ` Juri Linkov
2020-07-08 6:27 ` Sean Whitton
2020-07-09 0:10 ` Juri Linkov
2020-07-11 17:09 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zb1hfpy.fsf@iris.silentflame.com \
--to=spwhitton@spwhitton.name \
--cc=42210@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=drew.adams@oracle.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).