From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Philip K." Newsgroups: gmane.emacs.bugs Subject: bug#42386: Acknowledgement ([PATCH] Handle symbols in project-kill-buffers-ignores) Date: Thu, 16 Jul 2020 10:47:43 +0200 Message-ID: <875zankfrk.fsf@warpmail.net> References: <878sfjkh8o.fsf@warpmail.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25999"; mail-complaints-to="usenet@ciao.gmane.io" To: 42386@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 16 10:48:55 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jvzZX-0006gg-7B for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jul 2020 10:48:55 +0200 Original-Received: from localhost ([::1]:44376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jvzZW-00014S-9g for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jul 2020 04:48:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jvzYg-0000WE-1y for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 04:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43044) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jvzYf-0007Q9-PA for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 04:48:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jvzYf-0004SC-M4 for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 04:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Philip K." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jul 2020 08:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42386 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42386-submit@debbugs.gnu.org id=B42386.159488927617110 (code B ref 42386); Thu, 16 Jul 2020 08:48:01 +0000 Original-Received: (at 42386) by debbugs.gnu.org; 16 Jul 2020 08:47:56 +0000 Original-Received: from localhost ([127.0.0.1]:54590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jvzYa-0004Ru-HE for submit@debbugs.gnu.org; Thu, 16 Jul 2020 04:47:56 -0400 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:49441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jvzYX-0004Rf-GN for 42386@debbugs.gnu.org; Thu, 16 Jul 2020 04:47:55 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 9A6773E9 for <42386@debbugs.gnu.org>; Thu, 16 Jul 2020 04:47:47 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 16 Jul 2020 04:47:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:subject:in-reply-to:date:message-id:mime-version :content-type; s=fm3; bh=/ix52uESQX/DC3QzqAWk8wq4YNzZZC298DX6qOP VMFY=; b=CR45O3B151CCEOolqr6bjcSUqlPCL6MVp7lkNO2eBKJMH6nUDMfZqxa vl8DzeffB1Q2mwat5WIEpy5+woKcyU9unmuin4lqyc9w7Ils+8nVXke4YTz7QE3t ddMEOCE1iakTAdn+IDm7pQPLfJCj2C/QVHJaBWulp9ejToZWEoDUTBVNv0t7Guih dlF4T+RvKZt9HwJMe4/SAPWAWZtaNRi/GJTpP9rkpDilkPxi8nu71dZD57HHlzOY w9sjo9MJSO+ZPA1lp3AODbw3/ZzH1kxlHjGdPv4lxH25GMTHAnt+H1yfMeICxudG IzfU18tj8HZDy9fHtHEBMOptdWWyZyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=/ix52uESQX/DC3Qzq AWk8wq4YNzZZC298DX6qOPVMFY=; b=rFfjDIF7BB/hSGtSRvfPZFFVJMgM/i6TQ S50FGl+j5lwkb1VUILnMxIKchbQTB+MPvGFl8QnQpzNSH2rkj43+UjMIgWxujaYk pOG8udT2nrdQS09yxnytSK6Ae9BLYG7jTV+x2Xpgtyyqr5NM3k1XKnDKxmtpnNje NkOsXbHMW+BUhbBCN/1MUWWl/wKhgAiik8IPH9NKNE4W4crTmHfcqzG01zZCgwPf AcRkbJWKEhHgsjyqFec+zhVe4jqdCxNgdhCH5Ntiu+uFBz3dXM/jXVTIc34KvRdo gz2emKNwIrttkyOSSOgeDGZJgEV1UQ0AXq5LeCr8rRMaO4JlXqqUA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrfeeggddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfffkgggtsehmtderredttd dtnecuhfhrohhmpedfrfhhihhlihhpucfmrddfuceophhhihhlihhpseifrghrphhmrghi lhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeeiuedvleelffefgfeuteekleekgeevff eifeffhffgueeuhedvledvueevhfegnecukfhppeekjedrudeghedrtddrudehieenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehphhhilhhiph esfigrrhhpmhgrihhlrdhnvght X-ME-Proxy: Original-Received: from localhost (p5791009c.dip0.t-ipconnect.de [87.145.0.156]) by mail.messagingengine.com (Postfix) with ESMTPA id B079E30600A3 for <42386@debbugs.gnu.org>; Thu, 16 Jul 2020 04:47:46 -0400 (EDT) In-Reply-To: (help-debbugs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183043 Archived-At: --=-=-= Content-Type: text/plain Didn't properly test the last patch, sorry for that. The previous version would try to call the major mode initialisation as a predicate. -- Philip K. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Handle-symbols-in-project-kill-buffers-ignores.patch >From 01df630f6bfa8939b2df53f31882e3ef9fd7dfa1 Mon Sep 17 00:00:00 2001 From: Philip K Date: Thu, 16 Jul 2020 10:03:35 +0200 Subject: [PATCH] Handle symbols in project-kill-buffers-ignores --- lisp/progmodes/project.el | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 67ce3dc7d9..811c18cb56 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -847,10 +847,11 @@ project-kill-buffers-ignores '("\\*Help\\*") "Conditions for buffers `project-kill-buffers' should not kill. Each condition is either a regular expression matching a buffer -name, or a predicate function that takes a buffer object as -argument and returns non-nil if it matches. Buffers that match -any of the conditions will not be killed." - :type '(repeat (choice regexp function)) +name, a predicate function that takes a buffer object as argument +and returns non-nil if it matches, or a symbol protecting buffers +of certain major modes. Buffers that match any of the conditions +will not be killed." + :type '(repeat (choice regexp function symbol)) :version "28.1" :package-version '(project . "0.5.0")) @@ -877,7 +878,12 @@ project-kill-buffers (lambda (c) (cond ((stringp c) (string-match-p c (buffer-name buf))) - ((functionp c) + ((and (symbolp c) + (provided-mode-derived-p + (buffer-local-value 'major-mode buf) + c))) + ((and (not (symbolp c)) + (functionp c)) (funcall c buf)))) project-kill-buffers-ignores) (push buf bufs))) -- 2.20.1 --=-=-=--