From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: 29541@debbugs.gnu.org
Subject: bug#29541: 27.0.50; Use generic function when restoring eieio-persistent, remove validation
Date: Mon, 10 Aug 2020 16:05:04 +0200 [thread overview]
Message-ID: <875z9q38bz.fsf@gnus.org> (raw)
In-Reply-To: <m3lfxqohhf.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 24 Jun 2019 22:28:44 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
>> 1. `object-write' is already a method. That means the writing process
>> can be overridden and customized, but the reading process can't, which
>> removes most of the benefit of being able to override the write. This
>> would allow "matching" methods for writing and reading.
>
> This makes sense, and having a method instead of a function here
> certainly seems cleaner...
>
> Did anybody with a deeper knowledge of the eieio machinery provide any
> feedback? It's a quite large patch...
There wasn't any feedback here, so I think that you should go ahead and
apply the patch, Eric. I think it makes sense conceptually, at least.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-08-10 14:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-03 0:10 bug#29541: 27.0.50; Use generic function when restoring eieio-persistent, remove validation Eric Abrahamsen
2019-06-24 20:28 ` Lars Ingebrigtsen
2020-08-10 14:05 ` Lars Ingebrigtsen [this message]
2020-08-28 1:40 ` Eric Abrahamsen
2020-08-28 1:41 ` Eric Abrahamsen
2020-08-28 14:18 ` Lars Ingebrigtsen
2020-08-28 15:24 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z9q38bz.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=29541@debbugs.gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).