From: Tino Calancha <tino.calancha@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 39145@debbugs.gnu.org
Subject: bug#39145: 28.0.50; dired: Show broken/circular links in different font
Date: Mon, 24 Aug 2020 19:52:50 +0200 [thread overview]
Message-ID: <875z98orrh.fsf@gmail.com> (raw)
In-Reply-To: <87tv4wxsci.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 16 Jan 2020 01:13:32 +0200")
Juri Linkov <juri@linkov.net> writes:
>> @@ -538,6 +549,18 @@ dired-font-lock-keywords
>> (list dired-re-dir
>> '(".+" (dired-move-to-filename) nil (0 dired-directory-face)))
>> ;;
>> + ;; Broken Symbolic link.
>> + (list dired-re-sym
>> + (list (lambda (end)
>> + (let* ((file (dired-file-name-at-point))
>> + (truename (ignore-errors (file-truename file))))
>> + ;; either links to unexistent files or circular links
>> + (and (not (and truename (file-exists-p truename)))
>> + (search-forward-regexp ".+-> ?.+" end t))))
>> + '(dired-move-to-filename)
>
> Does this mean file-exists-p will be called on every file in the directory?
No it doesn't.
It will called only on symbolic links w/ a truename in such a dir.
prev parent reply other threads:[~2020-08-24 17:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 21:06 bug#39145: 28.0.50; dired: Show broken/circular links in different font Tino Calancha
2020-01-15 22:28 ` Glenn Morris
2020-08-24 18:05 ` Tino Calancha
2020-08-25 16:34 ` Tino Calancha
2020-08-25 16:51 ` Eli Zaretskii
2020-08-25 17:05 ` Tino Calancha
2020-08-25 17:18 ` Tino Calancha
2020-08-25 18:22 ` Eli Zaretskii
2020-08-27 8:30 ` Tino Calancha
2020-08-27 9:03 ` Eli Zaretskii
2020-08-27 9:37 ` Stefan Kangas
2020-08-27 9:58 ` Tino Calancha
2020-01-15 23:13 ` Juri Linkov
2020-08-24 17:52 ` Tino Calancha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z98orrh.fsf@gmail.com \
--to=tino.calancha@gmail.com \
--cc=39145@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).