unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: David Landell <david.landell@sunnyhill.email>
Cc: 43651@debbugs.gnu.org
Subject: bug#43651: 27.1; compile.el should not parse its own header for errors
Date: Tue, 29 Sep 2020 16:01:56 +0200	[thread overview]
Message-ID: <875z7wel63.fsf@gnus.org> (raw)
In-Reply-To: <874kniynf6.fsf@xwing.i-did-not-set--mail-host-address--so-tickle-me> (David Landell's message of "Mon, 28 Sep 2020 16:40:45 +0200")

David Landell <david.landell@sunnyhill.email> writes:

> I am attaching a patch that superficially seems to fix these issues.
> I have a hard time judging if this fix has any bad side effects or
> similar though.

Thanks for the analysis -- your patch was basically correct, I think,
but a bit brittle.  Instead of doing the marking with a variable, I've
now made compile mark the end of the header with a text property, and
that's then used to find the end of the header when pasing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      reply	other threads:[~2020-09-29 14:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-27 10:45 bug#43651: 27.1; compile.el should not parse its own header for errors David Landell
     [not found] ` <handler.43651.B.160122468524977.ack@debbugs.gnu.org>
2020-09-27 16:56   ` bug#43651: Acknowledgement (27.1; compile.el should not parse its own header for errors) David Landell
2020-09-28 13:46 ` bug#43651: 27.1; compile.el should not parse its own header for errors Lars Ingebrigtsen
2020-09-28 14:40   ` David Landell
2020-09-29 14:01     ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z7wel63.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=43651@debbugs.gnu.org \
    --cc=david.landell@sunnyhill.email \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).