From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: haj@posteo.de (Harald =?UTF-8?Q?J=C3=B6rg?=) Newsgroups: gmane.emacs.bugs Subject: bug#23461: perl-mode: Displaying HERE-docs as strings instead of comments [PATCH] Date: Tue, 05 Jan 2021 13:30:36 +0100 Message-ID: <875z4befbn.fsf@hajtower> References: <87sg7xxo0s.fsf@hajtower> <87zh24611c.fsf@hajtower> <87r1ng5pj8.fsf@hajtower> <87r1nfkyse.fsf@hajtower> <87czyk1d50.fsf@hajtower> <878s973fve.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28160"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 23461@debbugs.gnu.org, Stefan Monnier To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 05 13:31:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwlUY-0007Fb-ER for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Jan 2021 13:31:14 +0100 Original-Received: from localhost ([::1]:38288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwlUX-00031b-Fl for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Jan 2021 07:31:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwlUM-00031H-Ot for bug-gnu-emacs@gnu.org; Tue, 05 Jan 2021 07:31:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57718) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwlUM-0004G8-H7 for bug-gnu-emacs@gnu.org; Tue, 05 Jan 2021 07:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kwlUM-0006h2-Dz for bug-gnu-emacs@gnu.org; Tue, 05 Jan 2021 07:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: haj@posteo.de (Harald =?UTF-8?Q?J=C3=B6rg?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Jan 2021 12:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23461 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 23461-submit@debbugs.gnu.org id=B23461.160984984824910 (code B ref 23461); Tue, 05 Jan 2021 12:31:02 +0000 Original-Received: (at 23461) by debbugs.gnu.org; 5 Jan 2021 12:30:48 +0000 Original-Received: from localhost ([127.0.0.1]:41031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwlU7-0006TO-Sc for submit@debbugs.gnu.org; Tue, 05 Jan 2021 07:30:48 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:52817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwlU5-0006M4-Qn for 23461@debbugs.gnu.org; Tue, 05 Jan 2021 07:30:46 -0500 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 7AE7F240100 for <23461@debbugs.gnu.org>; Tue, 5 Jan 2021 13:30:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1609849838; bh=Jkq0+2kJghCok+raccwlCPMJAtWK/TqthMirxfDajMg=; h=From:To:Cc:Subject:Date:From; b=GUHvw38tBHV80EycZCRLfF+RcOOB6npayiP5D15YhA3AlcIdMlrTLgmHXn4tZghUP ZSNlbA7WHKFjt2cC1xJUPxcHGsnkdAdFf462ps62R/7fYop/ZNfKFFnBb7gxlPVZ4n SrTyKAjFY+s2XqwDnQ1G4w40bH8wMjUrJEz4vlLBXktTKzVKlm7Pf4IjAUDr2yVznL ph/WQZe86mpcoykkVky8l0cq60nc2N0AFSNCIFj29R70ZtML6b21+i/Qb19MPonRsT K9i8bfj17bxCUcug2DL7Qde5O651rfOviAvrppnIB/M96qBMjB8i5lT5CdhV3250it lk+MzIwotLyvg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4D9Bfj3PQ9z9rxQ; Tue, 5 Jan 2021 13:30:37 +0100 (CET) In-Reply-To: <878s973fve.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 05 Jan 2021 10:14:13 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197375 Archived-At: Lars Ingebrigtsen writes: > haj@posteo.de (Harald J=C3=B6rg) writes: > >> The trick: The lone "#" is now syntaxified as "whitespace" and >> font-lock-faced as comment. This is ugly, but also well-contained in >> the offending line, so should not have unwanted effects at a distance. >> >> The tests are designed for, and pass, for both Perl mode and CPerl mode. > > Thanks; applied to Emacs 28. However, the cperl tests failed -- I stuck > a (require 'perl-mode) into the test, and that made it work. I don't > know whether that's the proper solution here, though -- please have a loo= k. Ouch - and thanks! Adding (require 'perl-mode) is the correct thing to do. In my batch tests I loaded it explicitly for no good reason, I've eliminated that now. The tests need both modes to account for different names of custom variables (here: cperl-continued-statement-offset vs. perl-continued-statement-offset) which affect the expected outcome. --=20 Thanks again, haj