From: haj@posteo.de (Harald Jörg)
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 23461@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#23461: perl-mode: Displaying HERE-docs as strings instead of comments [PATCH]
Date: Tue, 05 Jan 2021 13:30:36 +0100 [thread overview]
Message-ID: <875z4befbn.fsf@hajtower> (raw)
In-Reply-To: <878s973fve.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 05 Jan 2021 10:14:13 +0100")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> haj@posteo.de (Harald Jörg) writes:
>
>> The trick: The lone "#" is now syntaxified as "whitespace" and
>> font-lock-faced as comment. This is ugly, but also well-contained in
>> the offending line, so should not have unwanted effects at a distance.
>>
>> The tests are designed for, and pass, for both Perl mode and CPerl mode.
>
> Thanks; applied to Emacs 28. However, the cperl tests failed -- I stuck
> a (require 'perl-mode) into the test, and that made it work. I don't
> know whether that's the proper solution here, though -- please have a look.
Ouch - and thanks!
Adding (require 'perl-mode) is the correct thing to do. In my batch
tests I loaded it explicitly for no good reason, I've eliminated that
now.
The tests need both modes to account for different names of custom
variables (here: cperl-continued-statement-offset
vs. perl-continued-statement-offset) which affect the expected outcome.
--
Thanks again,
haj
prev parent reply other threads:[~2021-01-05 12:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 21:03 bug#23461: perl mode uses same color for comments and here documents 積丹尼 Dan Jacobson
2019-10-09 5:52 ` Lars Ingebrigtsen
2020-12-23 2:19 ` bug#23461: perl-mode: Displaying HERE-docs as strings instead of comments [PATCH] Harald Jörg
2020-12-23 4:00 ` Stefan Monnier
2020-12-23 14:37 ` Harald Jörg
2020-12-23 16:34 ` Stefan Monnier
2020-12-23 18:46 ` Harald Jörg
2020-12-23 19:04 ` Stefan Monnier
2020-12-23 19:06 ` Stefan Monnier
2020-12-24 15:29 ` Harald Jörg
2020-12-24 17:32 ` Stefan Monnier
2021-01-04 23:43 ` Harald Jörg
2021-01-05 9:14 ` Lars Ingebrigtsen
2021-01-05 12:30 ` Harald Jörg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z4befbn.fsf@hajtower \
--to=haj@posteo.de \
--cc=23461@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).