From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks Date: Wed, 20 Jan 2021 04:58:27 +0100 Message-ID: <875z3suun0.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12530"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 13692@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 20 05:02:47 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l24hj-0003BB-Pm for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Jan 2021 05:02:47 +0100 Original-Received: from localhost ([::1]:37046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l24hi-0000WY-Py for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jan 2021 23:02:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l24e6-0006BS-7W for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 22:59:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40872) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l24e5-0007EA-Ub for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 22:59:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l24e5-0006w2-UP for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 22:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Jan 2021 03:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13692 X-GNU-PR-Package: emacs Original-Received: via spool by 13692-submit@debbugs.gnu.org id=B13692.161111512126629 (code B ref 13692); Wed, 20 Jan 2021 03:59:01 +0000 Original-Received: (at 13692) by debbugs.gnu.org; 20 Jan 2021 03:58:41 +0000 Original-Received: from localhost ([127.0.0.1]:52418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l24dl-0006vQ-6k for submit@debbugs.gnu.org; Tue, 19 Jan 2021 22:58:41 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:39936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l24dj-0006vB-10 for 13692@debbugs.gnu.org; Tue, 19 Jan 2021 22:58:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VTL3rzIZhSHJdr7n85C9RPcLw7gNCbAQnBFquDlzoqc=; b=vKj3MdzE6LU1IysPNRvL4HVD6h 0q01JR3ehr/UGDeCmaMoQo9q7m1wbNjyjyQ8HCaavzCZLTyQwq6ucZqmnAO92ruucK3zlfEVmLHZt D9kFBkchqYroM5XOn2m7886Tx1aA5HvMVeyb1gzlqagHvezvaXNYg37kAIrEKcGBaDlY=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l24dY-0000Vr-Ix; Wed, 20 Jan 2021 04:58:32 +0100 X-Now-Playing: M.A. Jaiyesimi & His Crescent Bros. Band's _Nigeria 70 (No Wahala: Highlife, Afro-Funk & Juju 1973-1987)_: "Mundiya Loju" In-Reply-To: (Glenn Morris's message of "Mon, 11 Feb 2013 23:56:18 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198237 Archived-At: Glenn Morris writes: > Maybe it's just me, but I find it too easy to accidentally change the > marked files in a vc-dir buffer with careless mouse clicks. > > In a directory under version control with modified files: > > emacs -Q -f vc-dir > > The text that says "edited" (and the space following it all the way up > to the filename) runs vc-dir-toggle-mark on mouse clicks. I find this > makes it too easy to accidentally change the marked state when using the > mouse to select a different window or frame. > > In a dired buffer, there is no way to mark files with mouse clicks > AFAICS. I don't see why vc-dir needs one. (Confusingly, clicking on the > actual mark character itself at the start of the line in a vc-dir buffer > does nothing.) So the suggestion is to remove the `[mouse-2]' binding in `vc-dir-mode'. I've never used the functionality myself, but I can see that somebody might find this useful, but if we're going to have it, perhaps the clickable area should be extended to the mark character, too? (I think removing the binding after more than a decade in existence would be confusing.) Anybody got any opinions here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no