From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks Date: Sat, 23 Jan 2021 20:02:57 +0100 Message-ID: <875z3nv5lq.fsf@gnus.org> References: <875z3suun0.fsf@gnus.org> <87o8hijql0.fsf@gnus.org> <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38980"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Glenn Morris , 13692@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 23 20:04:26 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3OCw-000A0U-Bg for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jan 2021 20:04:26 +0100 Original-Received: from localhost ([::1]:53460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3OCv-0001Bc-6A for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jan 2021 14:04:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3OCY-00019r-VL for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 14:04:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51984) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3OCY-0005xF-0O for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 14:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l3OCX-0004d2-SW for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 14:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jan 2021 19:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13692 X-GNU-PR-Package: emacs Original-Received: via spool by 13692-submit@debbugs.gnu.org id=B13692.161142859217735 (code B ref 13692); Sat, 23 Jan 2021 19:04:01 +0000 Original-Received: (at 13692) by debbugs.gnu.org; 23 Jan 2021 19:03:12 +0000 Original-Received: from localhost ([127.0.0.1]:35297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3OBk-0004bz-Gp for submit@debbugs.gnu.org; Sat, 23 Jan 2021 14:03:12 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:55132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3OBj-0004bl-Dt for 13692@debbugs.gnu.org; Sat, 23 Jan 2021 14:03:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jETYSMjSHKg+U+m5/uj72yPdKDvkiKbuBE8HXg2rU4I=; b=diclVoRFYK8gCTL/F6yp7nGqI7 lf2nzgEFmfItOlZFOPD20FA5YHk3y4s8yMJcicc2vcyk7Docc0vEXgzxEmgleg3YYxzj1dQwCWyUQ sKDLKw+d7i7+hPRmmtbSUIDlS4wSQC4HeACm1tE8MH0I7iyQ8T/GEZlX6MR9OifsED6k=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3OBX-00048a-Ct; Sat, 23 Jan 2021 20:03:05 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEX8/PylqahUT0Yx OjccNTmzXi3///+ih99BAAAAAWJLR0QGYWa4fQAAAAlwSFlzAAALEgAACxIB0t1+/AAAAAd0SU1F B+UBFxIlOdKnSfYAAAF4SURBVDjLfZRtcgIhDIZXewEdPYANy//KxwFcxguAuf9VGiCBhZ02f9zJ 45uEkLAsYlcguy6zncBZsgCXyb8GW8xtl9Fvmw1k5yfS/bewB+67BbKTSbDbDJ5/CETydQSPY0m7 wk7hCNylRwrKqDHWvXwZTO9kGngRqP9DjO/km8ZIijdmhf9AT3LOwOmqWH1i8ODcSMAn89HYspd+ bFhMk5DS5PKeFXhsxuBVi9IdUBLIsIMIBUQB5FYqe2hGdAXKVQBQQMygZCdHBVVBjsi/DGqoCNZQ caAVh8rJFUXQmBSl19SvoSqKorNCowA+YG5WIhpRDthbon05p7SkN7EWhdLEs+Wjx035tXaxtL1e lC8XldvOgKbBytVudIM+olxtG4YCNKY2DDw+PoMVILTx4YFzQEAZ1wdukZmh8uVz60NtgK2wn/0a 5DEUBW/OnZOQDYsjEgoDg2DeNSeCf9Z5ObnuD+PT4HivpieDCFdqJn95lqiw/iz9AsXRwxoTRAM0 AAAAGXRFWHRjb21tZW50AENyZWF0ZWQgd2l0aCBHSU1Q569AywAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMS0wMS0yM1QxODozNzo1NyswMDowMADX2dYAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDEt MjNUMTg6Mzc6NTcrMDA6MDBximFqAAAAAElFTkSuQmCC X-Now-Playing: Herbert's _Part Four_: "Resident" In-Reply-To: <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> (Dmitry Gutov's message of "Sat, 23 Jan 2021 03:43:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198456 Archived-At: Dmitry Gutov writes: > We're talking about slightly different things. > > When I hear "mouse-2 binding", I think the global bidning in > vc-dir-mode-map, which affects how mouse-2 works also when clicking > outside of any buttons (on whitespace beside the buttons). And I think > that behavior is relatively weird and could be removed. I didn't even notice that `mouse-2' did stuff when outside the "buttons". And what it does is quite odd... hm, no, if you click after the final line, it'll mark the last line, and before the first, it'll mark the first, so perhaps that's logical? > But we also have the behavior of mouse-1 and mouse-2 clicks on the > "status" button. Which seem fairly sensible to me, but might be the > cause of Glenn's annoyance in this report because it's relatively easy > to click mouse-1 anywhere in the buffer by mistake. Yes, I think he was complaining about the "status" button. > Right. But if that is what is at issue here, I think the question > becomes whether to remove the "buttons" from that column (and keep the > mouse-2 binding globally) or whether to remove the mouse-2 binding, > but set up the buttons to continue working. Or make mouse-1 stop > working on the buttons but keep mouse-2 working everywhere (except the > file names, I guess?). I think removing the global mouse bindings and only having them on the "buttons" would be least surprising -- that's how most modes work. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no