From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git Date: Tue, 09 Feb 2021 18:30:46 +0200 Message-ID: <875z31td8p.fsf@protesilaos.com> References: <87czxc5cku.fsf@protesilaos.com> <83tuqnnc3s.fsf@gnu.org> <87pn1b4zxp.fsf@protesilaos.com> <87im73m4ki.fsf@gnus.org> <87im72o6r6.fsf@mail.linkov.net> <87czx9u4h9.fsf@protesilaos.com> <8735y538wi.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34483"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46358@debbugs.gnu.org, Lars Ingebrigtsen , Dmitry Gutov To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 09 17:32:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9Vw8-0008sO-9u for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Feb 2021 17:32:24 +0100 Original-Received: from localhost ([::1]:38926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9Vw7-0006Ae-DM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Feb 2021 11:32:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9Vvm-00067l-Kk for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 11:32:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9Vvm-0006sq-26 for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 11:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9Vvl-00056Y-VB for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 11:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Feb 2021 16:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46358 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 46358-submit@debbugs.gnu.org id=B46358.161288826219544 (code B ref 46358); Tue, 09 Feb 2021 16:32:01 +0000 Original-Received: (at 46358) by debbugs.gnu.org; 9 Feb 2021 16:31:02 +0000 Original-Received: from localhost ([127.0.0.1]:54455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9Vuo-000559-0f for submit@debbugs.gnu.org; Tue, 09 Feb 2021 11:31:02 -0500 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:34161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9Vul-00054d-68 for 46358@debbugs.gnu.org; Tue, 09 Feb 2021 11:31:00 -0500 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id B46C1240013; Tue, 9 Feb 2021 16:30:50 +0000 (UTC) In-Reply-To: <8735y538wi.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 09 Feb 2021 11:19:01 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199699 Archived-At: On 2021-02-09, 11:19 +0200, Juri Linkov wrote: >>>> Maybe better to display the empty Git stash header using the default >>>> colors, and then highlight it differently only when it's non-empty? >>> >>> Not with vc-dir-ignored, though (it is based on the 'shadow' face). >> >> Before this change, the empty stash looked the same as all other >> headers' values. > > It could continue looking the same as all other headers' values. Thinking again about this, I now agree with this view. An empty stash is not an "inactive" status but rather a valid header value. >> This meant that there was no distinction between empty and non-empty >> stashes, something that was noted as a "FIXME" in the source code. > > Indeed, it could be better to have a distinction between empty and > non-empty stashes. The FIXME proposed to use a different face > when nothing is stashed. > > But it seems better to use a different face when something is stashed. > It's important to attract user attention to the fact that there are > stashes laying around. I actually feel that this level of distinction already exists. When the stash is non-empty, there is a button/link which by default is blue, so it contrasts well with the orange header values. This button can be used to toggle the visibility of the stash list. Stash entries are the same color as all other header values, yet their presence is already quite obvious in context. >> I think there is value in distinguishing between those two states, >> though I am fine with some other choice of fallback color/face. >> Currently the empty stash uses 'vc-dir-ignored' which inherits from >> 'shadow'. Whereas others use 'vc-dir-header-value' which inherit from >> 'font-lock-variable-name-face'. > > Could some of new vc-dir faces that you added recently > be used for non-empty stashes? In principle yes, though I now believe that we do not need to introduce such a qualification. >> If you feel this is a problem 'vc-dir-ignored' could also inherit from >> 'font-lock-variable-name-face'. > > It's good that 'vc-dir-ignored' inherits from the 'shadow' face > when it's used on files with the "ignored" status. Then it > could be renamed to 'vc-dir-status-ignored' as you already proposed. Yes, it should be renamed. I will now use this information, as well as what Dmitry shared in the other comment to prepare a new patch that covers everything. You can all test it before it gets applied. I will share it in this thread either later in the day or tomorrow. Thank you! -- Protesilaos Stavrou protesilaos.com