From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#46827: Broken initial size of GTK3 frame Date: Mon, 01 Mar 2021 14:30:58 +0100 Message-ID: <875z2b3srx.fsf@gmail.com> References: <6caa020a-084c-e3f2-7a34-262f7127b21b@gmx.at> <87eegz41ui.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8956"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46827@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 01 14:37:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGijX-0002Fq-H8 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 14:37:11 +0100 Original-Received: from localhost ([::1]:52378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGijW-0000aR-F5 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 08:37:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGieY-00054z-L5 for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 08:32:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36954) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGieY-0008Gm-BD for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 08:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lGieY-0003LD-7I for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 08:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Mar 2021 13:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46827 X-GNU-PR-Package: emacs Original-Received: via spool by 46827-submit@debbugs.gnu.org id=B46827.161460546910245 (code B ref 46827); Mon, 01 Mar 2021 13:32:02 +0000 Original-Received: (at 46827) by debbugs.gnu.org; 1 Mar 2021 13:31:09 +0000 Original-Received: from localhost ([127.0.0.1]:48500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGidg-0002eo-Jn for submit@debbugs.gnu.org; Mon, 01 Mar 2021 08:31:08 -0500 Original-Received: from mail-wm1-f43.google.com ([209.85.128.43]:39462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGide-0002Wn-9r for 46827@debbugs.gnu.org; Mon, 01 Mar 2021 08:31:06 -0500 Original-Received: by mail-wm1-f43.google.com with SMTP id u125so14463460wmg.4 for <46827@debbugs.gnu.org>; Mon, 01 Mar 2021 05:31:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=DyYopT/euWUjcyPafxq8zRUqfcQMwZlxtgmdkIKGFYA=; b=pO41DCoCGwX+IVW2CqK+XYaWK0i6kjnl84DuGozQWoHFskBXC1oep5La2j02YDH1Zy o0dPEX35j/pm8NuhLLccPnMM7egf0ln7yR+P+HRk72FJpa3ke6RAvjmGHR75oUz7/MS6 UK1aTtZphSaApyN5YPTbWRnVtu0pGsyQcYWGFeSl3k672KavCk5qPxKRbdpdGTzq746z 8H0moZrJcnmjz7IgVgznjhGcgO6U6Lpvm7l95zduYvghDydQCa+da/3SHr0R/SPLjXpJ 46L2BK+S3f6wnlGxeotUI5eU0385DvIoU/1tQhsH1jCyKrV0Q5o0GCm8dCwt82aQcgKI SeGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=DyYopT/euWUjcyPafxq8zRUqfcQMwZlxtgmdkIKGFYA=; b=YAc2FnYLVOxlRXrQ5K9a87oZ4FF5DbKWtRV7eGxPOpyiI9X5bySro26+0UvQElq5kP r46yHUfkTwtcjyFnlgs+YfKbm2M+cB7TqxuXPpaI/vK3Wr9Kwoojye9Xg4Bex1jQU0G2 0MOHfPI/GK/VOXdiEFy7rwDkyVSuZdgD9NuslqaTgwcHDpIiRLmXhWoiiOkjT64Fn2kw Ytuv8vrsKfrSY0FnS0UC3ayo731N1/53Q5sz1IV2RqF7Cd3kM9sOsKFvoBLZCw2nq/i2 2EUSA3aUFgn3sGcUPcvxQNiZvJZNbUHvNj4mtxE/qXRcyy+oRjXUbE4aDNxwizZucuww V5Dw== X-Gm-Message-State: AOAM530w5QluV2c26psgfjrVqMfSaa0US6pIhAtDFtENFTqvr2g4IGHJ mP98kUvfgWJJwZn0WHjX1+/41fHaN/rABg== X-Google-Smtp-Source: ABdhPJybgdrmf04ZVHVI2axREs2v/GAPTaFE4Bmaz04VSXoJ+QG+0RcBHQXYxJ8o+OHqTkCiiGnx5w== X-Received: by 2002:a1c:4b15:: with SMTP id y21mr16272036wma.94.1614605459761; Mon, 01 Mar 2021 05:30:59 -0800 (PST) Original-Received: from rltb (91-175-207-237.subs.proxad.net. [91.175.207.237]) by smtp.gmail.com with ESMTPSA id h22sm25618811wmb.36.2021.03.01.05.30.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Mar 2021 05:30:59 -0800 (PST) In-Reply-To: (martin rudalics's message of "Mon, 1 Mar 2021 13:38:58 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201090 Archived-At: >>>>> On Mon, 1 Mar 2021 13:38:58 +0100, martin rudalics = said: >> I=CA=BCll just say I don=CA=BCt see this with Gnome on Debian testin= g, with >> either emacs-27 or master, so once again it=CA=BCs window manager >> dependent. martin> What does (frame-height) give for your frame? 30. A lucid build gives me 31, so it=CA=BCs no better. (all emacs-27) I=CA=BCll install xfwm4 and see what happens. >> I=CA=BCm surprised that querying another font backend when we've alr= eady >> found a font causes frame sizing issues like this. Do we understand >> the cause here? martin> No. All I can say is that it is tool bar related. What happens if you disable the code that displays text labels in the tool bar: diff --git a/src/gtkutil.c b/src/gtkutil.c index 825fbe1d45..425b0727e9 100644 --- a/src/gtkutil.c +++ b/src/gtkutil.c @@ -4708,8 +4708,6 @@ xg_make_tool_item (struct frame *f, =20 if (wimage && !text_image) gtk_box_pack_start (GTK_BOX (vb), wimage, TRUE, TRUE, 0); - if (label) - gtk_box_pack_start (GTK_BOX (vb), gtk_label_new (label), TRUE, TRUE, 0= ); if (wimage && text_image) gtk_box_pack_start (GTK_BOX (vb), wimage, TRUE, TRUE, 0); =20 @@ -4723,7 +4721,7 @@ xg_make_tool_item (struct frame *f, gtk_container_add (GTK_CONTAINER (weventbox), wb); gtk_container_add (GTK_CONTAINER (ti), weventbox); =20 - if (wimage || label) + if (wimage) { intptr_t ii =3D i; gpointer gi =3D (gpointer) ii; >> We can revert the bug#43177 fix of course, but perhaps we should make >> it conditional on !GTK3 || PGTK or something? martin> First I'd like to fix the behavior for Emacs 27, conceptually a= t least. martin> Then we can discuss Bug#43177. Works for me. Robert --=20