From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#46859: 28.0.50; [PATCH]: Add option to truncate long lines in xref.el Date: Wed, 03 Mar 2021 21:59:39 +0200 Organization: LINKOV.NET Message-ID: <875z282el0.fsf@mail.linkov.net> References: <87im69uzlt.fsf@mail.linkov.net> <878s74fv27.fsf@mail.linkov.net> <4119ea3055ef8f306fc0@heytings.org> <4119ea30557ef84ca190@heytings.org> <7eb7ee0f-7dba-c90d-cb58-af42c3828643@yandex.ru> <4119ea30554b406efbbf@heytings.org> <4119ea30558f1e4145b0@heytings.org> <4119ea30555e80bdcf7e@heytings.org> <1c82e582-8b90-f3c5-5391-1e88ca4e7ab2@yandex.ru> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9376"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Gregory Heytings , 46859@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 03 21:02:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHXhJ-0002Jj-Fr for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Mar 2021 21:02:17 +0100 Original-Received: from localhost ([::1]:45142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHXhI-00077X-Hs for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Mar 2021 15:02:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHXh4-00076o-AO for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 15:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45530) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHXh4-0004zy-1T for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 15:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHXh3-0003r7-Vj for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 15:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Mar 2021 20:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46859 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46859-submit@debbugs.gnu.org id=B46859.161480172014807 (code B ref 46859); Wed, 03 Mar 2021 20:02:01 +0000 Original-Received: (at 46859) by debbugs.gnu.org; 3 Mar 2021 20:02:00 +0000 Original-Received: from localhost ([127.0.0.1]:57075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHXh2-0003qj-Bh for submit@debbugs.gnu.org; Wed, 03 Mar 2021 15:02:00 -0500 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:50145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHXh0-0003qJ-3S for 46859@debbugs.gnu.org; Wed, 03 Mar 2021 15:01:58 -0500 X-Originating-IP: 91.129.96.116 Original-Received: from mail.gandi.net (m91-129-96-116.cust.tele2.ee [91.129.96.116]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 8736920002; Wed, 3 Mar 2021 20:01:50 +0000 (UTC) In-Reply-To: <1c82e582-8b90-f3c5-5391-1e88ca4e7ab2@yandex.ru> (Dmitry Gutov's message of "Wed, 3 Mar 2021 21:14:02 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201320 Archived-At: --=-=-= Content-Type: text/plain > We currently don't visit the file buffer if it's not already visited, > parsing the line in a temp buffer instead. That approach resulted in a nice > perf improvement. Reusing visited files is a nice feature, but still needs a fix. Test case: visit emacs/src/xdisp.c and type C-x p g expose_frame RET See that not all lines from xdisp.c have font-lock highlighting. After applying this patch, all xref output lines from xdisp.c have font-lock faces: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=xref-font-lock-ensure.patch diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 18fdd963fb..6a5361f852 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -1691,7 +1701,10 @@ xref--collect-matches-1 (let* ((beg-column (- (match-beginning 0) line-beg)) (end-column (- (match-end 0) line-beg)) (loc (xref-make-file-location file line beg-column)) - (summary (buffer-substring line-beg line-end))) + (summary (progn + (unless syntax-needed + (font-lock-ensure line-beg line-end)) + (buffer-substring line-beg line-end)))) (add-face-text-property beg-column end-column 'xref-match t summary) (push (xref-make-match summary loc (- end-column beg-column)) --=-=-=--