From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Date: Thu, 04 Mar 2021 06:53:06 +0200 Message-ID: <875z27bjv1.fsf@protesilaos.com> References: <87im9fgm27.fsf@protesilaos.com> <87sg6po0yd.fsf_-_@protesilaos.com> <83czxt2fpd.fsf@gnu.org> <87h7m0n0em.fsf@protesilaos.com> <83v9agryuz.fsf@gnu.org> <87tupyw83e.fsf@protesilaos.com> <83zgzqncxx.fsf@gnu.org> <874khwn1qf.fsf@protesilaos.com> <603b8171.1c69fb81.aa664.7f40@mx.google.com> <87mtvoxsvs.fsf@protesilaos.com> <603b9b9d.1c69fb81.f37aa.cb7c@mx.google.com> <83eegz7xcx.fsf@gnu.org> <87o8g3exjv.fsf@protesilaos.com> <603d053a.1c69fb81.f4cb8.fb14@mx.google.com> <87h7luga3p.fsf@protesilaos.com> <87o8g2bg89.fsf@tcd.ie> <87r1kyrtrl.fsf@protesilaos.com> <878s75x2uk.fsf@tcd.ie> <87o8g0ryfz.fsf@tcd.ie> <871rcw8631.fsf@protesilaos.com> <87wnunbrnq.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7545"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Mauro Aranda , 45068@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 04 05:54:32 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHg0O-0001qr-NC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 05:54:32 +0100 Original-Received: from localhost ([::1]:60542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHg0N-0005OK-QX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Mar 2021 23:54:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHfzt-0005OC-WE for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 23:54:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45866) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHfzt-0006Ek-Ka for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 23:54:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHfzt-000610-IR for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 23:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Mar 2021 04:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.161483359723069 (code B ref 45068); Thu, 04 Mar 2021 04:54:01 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 4 Mar 2021 04:53:17 +0000 Original-Received: from localhost ([127.0.0.1]:57412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHfzB-000601-4X for submit@debbugs.gnu.org; Wed, 03 Mar 2021 23:53:17 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:51205) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHfzA-0005zp-5J for 45068@debbugs.gnu.org; Wed, 03 Mar 2021 23:53:16 -0500 X-Originating-IP: 94.46.225.161 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id BC6E01C0004; Thu, 4 Mar 2021 04:53:08 +0000 (UTC) In-Reply-To: <87wnunbrnq.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 04 Mar 2021 02:04:41 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201359 Archived-At: On 2021-03-04, 02:04 +0000, "Basil L. Contovounesios" wrote: > Protesilaos Stavrou writes: > >> I applied it and it works for what I want to do. The decoupling feels >> more appropriate. > > Thanks for reviewing it. You are welcome! >> The major difference I see between evaluating 'require-theme' and >> 'require' forms is that the latter errors with a backtrace buffer, while >> the former logs a message. >> >> Compare those: >> >> (require 'give-me-error) >> (require-theme 'give-me-error) > > Hm, how are you evaluating them? Here's what I tried: > > [...] > > The patch implements require-theme in terms of require, > so even the error symbol and data should be identical. My bad! I was trying the patch in emacs -Q and then went to my unpatched Emacs' scratch buffer... >> At any rate, tomorrow I will share with you the new version of my themes >> and their manual. > > I look forward to it. Will finalise the changelog entry and update this thread. Probably within 8 hours or so. -- Protesilaos Stavrou protesilaos.com