From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 46992@debbugs.gnu.org
Subject: bug#46992: xref-after-update-hook
Date: Mon, 08 Mar 2021 19:48:48 +0200 [thread overview]
Message-ID: <875z21wn7j.fsf@mail.linkov.net> (raw)
In-Reply-To: <87r1kqhkzu.fsf@mail.linkov.net>
tags 46992 fixed
close 46992 28.0.50
thanks
>> This is the first thing that I tried, but the problem is that
>> it's called before the xref buffer is filled with results
>> where I need to put overlays on output lines.
>> Also the hook needs to be called after reverting xref buffer.
>
> I figured if all you are doing is some setup and turning on a minor mode,
> it should be enough to only do once. A minor mode would generally track all
> subsequent modifications to the buffer with after-change-functions or the
> like (we don't bind (inhibit-modification-hooks t) while rendering the
> output, although it looks like we might, for a small extra speed boost).
We can't overburden minor modes with such complexity that is not used
most of the time.
> But if that doesn't work for some reason, or doesn't cover all your goals,
> please feel free to install the patch.
Ok, pushed to master, and closed.
prev parent reply other threads:[~2021-03-08 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 18:50 bug#46992: xref-after-update-hook Juri Linkov
2021-03-07 19:29 ` Dmitry Gutov
2021-03-07 20:43 ` Juri Linkov
2021-03-08 0:09 ` Dmitry Gutov
2021-03-08 17:48 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z21wn7j.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=46992@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).