From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#47167: [External] : bug#47167: Multi-line comment-region with empty comment-continue Date: Wed, 17 Mar 2021 19:04:20 +0200 Organization: LINKOV.NET Message-ID: <875z1piw91.fsf@mail.linkov.net> References: <87a6r4muw5.fsf@mail.linkov.net> <87ft0vwhty.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33657"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: "47167@debbugs.gnu.org" <47167@debbugs.gnu.org> To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 17 18:37:56 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMa7G-0008ci-To for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Mar 2021 18:37:54 +0100 Original-Received: from localhost ([::1]:44034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMa7F-0005Ym-Uk for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Mar 2021 13:37:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMZuq-0003Ld-Nu for bug-gnu-emacs@gnu.org; Wed, 17 Mar 2021 13:25:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60605) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMZuo-0001tr-Hc for bug-gnu-emacs@gnu.org; Wed, 17 Mar 2021 13:25:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lMZuo-0004oq-Bo for bug-gnu-emacs@gnu.org; Wed, 17 Mar 2021 13:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Mar 2021 17:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47167-submit@debbugs.gnu.org id=B47167.161600189918497 (code B ref 47167); Wed, 17 Mar 2021 17:25:02 +0000 Original-Received: (at 47167) by debbugs.gnu.org; 17 Mar 2021 17:24:59 +0000 Original-Received: from localhost ([127.0.0.1]:43915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMZul-0004oH-6X for submit@debbugs.gnu.org; Wed, 17 Mar 2021 13:24:59 -0400 Original-Received: from relay13.mail.gandi.net ([217.70.178.233]:64521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMZui-0004o2-RG for 47167@debbugs.gnu.org; Wed, 17 Mar 2021 13:24:57 -0400 Original-Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay13.mail.gandi.net (Postfix) with ESMTPSA id 93A9C80003; Wed, 17 Mar 2021 17:24:49 +0000 (UTC) In-Reply-To: (Drew Adams's message of "Tue, 16 Mar 2021 19:24:47 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202531 Archived-At: >> With (setq-local comment-style 'extra-line comment-continue ""), >> `comment-region' currently breaks HTML syntax >> because HTML doesn't support nested comments: >> >> >> >> >> --> >> >> With the proposed patch, HTML syntax stays valid: >> >> > > I see, I guess. But why change `comment-region', > instead of creating a new command for multi-line > (aka block) commenting? 'multi-line' is just one of possible styles in 'comment-styles'. I'm not interested in creating separate commands for each style. If you want, you can create a separate bug report. > If there's a bug now (e.g. wrt `comment-continue') > when someone uses `comment-region', then maybe > either that can be fixed (without involving > multiline) or that command can be made to ignore, Indeed, there is a bug. The documentation of 'comment-continue' says: Continuation string to insert for multiline comments. If it is nil a value will be automatically derived from ‘comment-start’ by replacing its first character with a space. The problem is that currently the empty string behaves as if it's nil. The patch fixes it.