From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#48180: ruby-mode.el: fix font lock for puts and printf Date: Mon, 03 May 2021 19:42:44 +0300 Organization: LINKOV.NET Message-ID: <875yzz24bf.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24440"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Steve Purcell , 48180@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 03 19:21:32 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldcGC-0006Gp-FH for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 19:21:32 +0200 Original-Received: from localhost ([::1]:34660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldcGB-0000fh-Io for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 13:21:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldc0G-0003tZ-3r for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 13:05:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36026) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldc0F-0008W0-GH for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 13:05:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldc0F-0000nR-Al for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 13:05:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 May 2021 17:05:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48180 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 48180-submit@debbugs.gnu.org id=B48180.16200614832989 (code B ref 48180); Mon, 03 May 2021 17:05:03 +0000 Original-Received: (at 48180) by debbugs.gnu.org; 3 May 2021 17:04:43 +0000 Original-Received: from localhost ([127.0.0.1]:47560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldbzv-0000m9-G2 for submit@debbugs.gnu.org; Mon, 03 May 2021 13:04:43 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:37475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldbzu-0000lj-26 for 48180@debbugs.gnu.org; Mon, 03 May 2021 13:04:42 -0400 X-Originating-IP: 91.129.102.166 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 16BDC40005; Mon, 3 May 2021 17:04:34 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Mon, 3 May 2021 13:17:48 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205538 Archived-At: >> Both these methods can be called without arguments, so the font >> locking of "bare" calls to either is incorrect. The fix is to >> font-lock them as for other kernel methods which accepts zero or more >> arguments. > > Is that important? Like, is anybody likely to call either without args? > font-lock is not a precise facility (that anything depends on), so we can > afford to be wrong in 0.01% cases. It always bothered me that in ruby-mode highlighting was broken for printing without arguments, but I had no time to investigate. Now finally this is fixed. Maybe some other printing like "p" could be fixed as well, but the already fixed "puts" and "print" is an improvement.