From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Steve Purcell <steve@sanityinc.com>, 48180@debbugs.gnu.org
Subject: bug#48180: ruby-mode.el: fix font lock for puts and printf
Date: Mon, 03 May 2021 19:42:44 +0300 [thread overview]
Message-ID: <875yzz24bf.fsf@mail.linkov.net> (raw)
In-Reply-To: <c654efe1-8019-b29a-98f8-519fa113794b@yandex.ru> (Dmitry Gutov's message of "Mon, 3 May 2021 13:17:48 +0300")
>> Both these methods can be called without arguments, so the font
>> locking of "bare" calls to either is incorrect. The fix is to
>> font-lock them as for other kernel methods which accepts zero or more
>> arguments.
>
> Is that important? Like, is anybody likely to call either without args?
> font-lock is not a precise facility (that anything depends on), so we can
> afford to be wrong in 0.01% cases.
It always bothered me that in ruby-mode highlighting was broken for printing
without arguments, but I had no time to investigate. Now finally this is fixed.
Maybe some other printing like "p" could be fixed as well, but the
already fixed "puts" and "print" is an improvement.
next prev parent reply other threads:[~2021-05-03 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 1:01 bug#48180: ruby-mode.el: fix font lock for puts and printf Steve Purcell
2021-05-03 7:41 ` Lars Ingebrigtsen
2021-05-03 10:17 ` Dmitry Gutov
2021-05-03 16:42 ` Juri Linkov [this message]
2021-05-03 20:31 ` Steve Purcell
2021-05-03 20:42 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yzz24bf.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=48180@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=steve@sanityinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).