unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 39886@debbugs.gnu.org, stefan@marxist.se
Subject: bug#39886: [PATCH] Add EPA keyserver client
Date: Wed, 12 May 2021 17:52:59 +0000	[thread overview]
Message-ID: <875yznyh38.fsf@posteo.net> (raw)
In-Reply-To: <87pmxvg90w.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 12 May 2021 19:24:31 +0200")

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>> No, that must have been a mistake. Should it fix it?
>
> Yes, a patch for that would be appreciated.

This should be more consistent:

-- 
	Philip K.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Don-t-mark-interactive-commands-as-internal-function.patch --]
[-- Type: text/x-diff, Size: 2484 bytes --]

From 6ef0a95dcd7f4344b563788a57abf9e504364c11 Mon Sep 17 00:00:00 2001
From: Philip K <philipk@posteo.net>
Date: Wed, 12 May 2021 19:27:54 +0200
Subject: [PATCH] Don't mark interactive commands as internal functions

---
 lisp/epa-ks.el | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/lisp/epa-ks.el b/lisp/epa-ks.el
index af2398c128..a33025b112 100644
--- a/lisp/epa-ks.el
+++ b/lisp/epa-ks.el
@@ -68,9 +68,9 @@ epa-ks-last-query
 (defvar epa-ks-search-mode-map
   (let ((map (make-sparse-keymap)))
     (suppress-keymap map)
-    (define-key map (kbd "f") #'epa-ks--mark-key-to-fetch)
-    (define-key map (kbd "i") #'epa-ks--inspect-key-to-fetch)
-    (define-key map (kbd "u") #'epa-ks--unmark-key-to-fetch)
+    (define-key map (kbd "f") #'epa-ks-mark-key-to-fetch)
+    (define-key map (kbd "i") #'epa-ks-inspect-key-to-fetch)
+    (define-key map (kbd "u") #'epa-ks-unmark-key-to-fetch)
     (define-key map (kbd "x") #'epa-ks-do-key-to-fetch)
     map))
 
@@ -89,19 +89,19 @@ epa-ks-search-mode
             nil t)
   (tabulated-list-init-header))
 
-(defun epa-ks--inspect-key-to-fetch ()
+(defun epa-ks-inspect-key-to-fetch ()
   "Display full ID of key under point in the minibuffer."
   (interactive)
   (message "Full ID: %s" (epa-ks-key-id (car (tabulated-list-get-id)))))
 
-(defun epa-ks--unmark-key-to-fetch ()
+(defun epa-ks-unmark-key-to-fetch ()
   "Remove fetch mark for key under point.
 
 If a region is active, unmark all keys in active region."
   (interactive)
-  (epa-ks--mark-key-to-fetch ""))
+  (epa-ks-mark-key-to-fetch ""))
 
-(defun epa-ks--mark-key-to-fetch (tag)
+(defun epa-ks-mark-key-to-fetch (tag)
   "Add fetch-mark to key under point.
 
 If a region is active, mark all keys in active region.
@@ -109,7 +109,7 @@ epa-ks--mark-key-to-fetch
 When all keys have been selected, use \\[epa-ks-do-key-to-fetch] to
 actually import the keys.
 
-When called interactively, `epa-ks--mark-key-to-fetch' will always
+When called interactively, `epa-ks-mark-key-to-fetch' will always
 add a \"F\" tag.  Non-interactivly the tag must be specified by
 setting the TAG parameter."
   (interactive (list "F"))
@@ -125,7 +125,7 @@ epa-ks--mark-key-to-fetch
 (defun epa-ks-do-key-to-fetch ()
   "Fetch all marked keys from keyserver and import them.
 
-Keys are marked using `epa-ks--mark-key-to-fetch'."
+Keys are marked using `epa-ks-mark-key-to-fetch'."
   (interactive)
   (save-excursion
     (let (keys)
-- 
2.30.2


  parent reply	other threads:[~2021-05-12 17:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03 16:23 bug#39886: [PATCH] Add EPA keyserver client Philip K
     [not found] ` <CADwFkm=iPrhJaBhntAFcQPnRerHSsTY1Lc1gihMR06fVrVR_cQ@mail.gmail.com>
2020-05-19 10:08   ` Philip K.
2020-05-19 13:50     ` Stefan Kangas
2020-08-08 13:59     ` Lars Ingebrigtsen
2020-08-08 14:42       ` Stefan Kangas
2020-08-08 14:51       ` Colin Baxter
2020-08-08 17:20       ` Philip K.
2020-08-09  9:52         ` Lars Ingebrigtsen
2020-08-09 11:28           ` Philip K.
2020-08-09 19:41             ` Lars Ingebrigtsen
2021-05-12 16:45               ` Lars Ingebrigtsen
2021-05-12 16:52                 ` Philip Kaludercic
2021-05-12 16:57                   ` Lars Ingebrigtsen
2021-05-12 17:10                 ` Eli Zaretskii
2021-05-12 17:23                   ` Philip Kaludercic
2021-05-12 17:24                     ` Lars Ingebrigtsen
2021-05-12 17:34                       ` Philip Kaludercic
2021-05-12 17:52                       ` Philip Kaludercic [this message]
2021-05-12 18:00                         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yznyh38.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=39886@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).