From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#48669: Inconsistent overlay placement between minibuffer-message and set-minibuffer-message Date: Sun, 06 Jun 2021 23:54:58 +0300 Organization: LINKOV.NET Message-ID: <875yyqlnml.fsf@mail.linkov.net> References: <87k0n8kl1h.fsf@mail.linkov.net> <83r1hfilfg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40160"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: joca.bt@gmail.com, 48669@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 06 23:16:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lq07w-000A9Y-F0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Jun 2021 23:16:12 +0200 Original-Received: from localhost ([::1]:55392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lq07v-0008T6-0U for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Jun 2021 17:16:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lq07n-0008RT-0v for bug-gnu-emacs@gnu.org; Sun, 06 Jun 2021 17:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42506) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lq07m-0008Cs-QT for bug-gnu-emacs@gnu.org; Sun, 06 Jun 2021 17:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lq07m-00006C-NT for bug-gnu-emacs@gnu.org; Sun, 06 Jun 2021 17:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Jun 2021 21:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48669 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48669-submit@debbugs.gnu.org id=B48669.162301412132765 (code B ref 48669); Sun, 06 Jun 2021 21:16:02 +0000 Original-Received: (at 48669) by debbugs.gnu.org; 6 Jun 2021 21:15:21 +0000 Original-Received: from localhost ([127.0.0.1]:54050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lq077-0008WP-JC for submit@debbugs.gnu.org; Sun, 06 Jun 2021 17:15:21 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:57043) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lq075-0008Vh-Ig for 48669@debbugs.gnu.org; Sun, 06 Jun 2021 17:15:20 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 9E3331BF205; Sun, 6 Jun 2021 21:15:12 +0000 (UTC) In-Reply-To: <83r1hfilfg.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 06 Jun 2021 08:58:27 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208158 Archived-At: >> @@ -741,7 +741,8 @@ minibuffer-message >> ;; Don't overwrite the face properties the caller has set >> (text-properties-at 0 message)) >> (setq message (apply #'propertize message minibuffer-message-properties))) >> - (let ((ol (make-overlay (point-max) (point-max) nil t t)) >> + (let* ((ovpos (minibuffer--message-overlay-pos)) >> + (ol (make-overlay ovpos ovpos nil t t)) > > Doesn't this rely too much on the internal details of > minibuffer--message-overlay-pos? At least, without any comments, this > call looks like a riddle that isn't easy to unlock. If minibuffer--message-overlay-pos serves its purpose for set-minibuffer-message, it seems suitable for minibuffer-message as well. >> - (put-text-property 0 1 'cursor t message)) >> + (put-text-property 0 1 'cursor 1 message)) > > Why this change? Only to make minibuffer-message the identical copy of set-minibuffer-message.