From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50560: 28.0.50; 'insert-file-contents-literally' on multibyte buffers Date: Mon, 13 Sep 2021 09:10:59 +0200 Message-ID: <875yv5j6gs.fsf@gnus.org> References: <87zgshotc1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18654"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50560@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 13 09:12:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPg8S-0004fp-N2 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Sep 2021 09:12:12 +0200 Original-Received: from localhost ([::1]:41826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPg8R-0003NE-9l for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Sep 2021 03:12:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPg8K-0003Mx-01 for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 03:12:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60713) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPg8I-0006b4-P8 for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 03:12:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mPg8I-00080b-Gu for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 03:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Sep 2021 07:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50560 X-GNU-PR-Package: emacs Original-Received: via spool by 50560-submit@debbugs.gnu.org id=B50560.163151707030721 (code B ref 50560); Mon, 13 Sep 2021 07:12:02 +0000 Original-Received: (at 50560) by debbugs.gnu.org; 13 Sep 2021 07:11:10 +0000 Original-Received: from localhost ([127.0.0.1]:44026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPg7R-0007zR-SI for submit@debbugs.gnu.org; Mon, 13 Sep 2021 03:11:10 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:54842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPg7Q-0007zD-09 for 50560@debbugs.gnu.org; Mon, 13 Sep 2021 03:11:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=b3WsvRAYO0sQWMcqAw1+4hS5ilvUEOizWtWOqVLEf58=; b=nvqdk/NlbbuAhC51dhLJ4il16o KC86o505GnYpKRd4KQzYHQoNXRGxvSNNzi9ROjzv+NFGrSHfKNST5IflVOqeVK+g1vyn7V8t4ijcq aTFc1a2WMUYyBMWj8xGTTZp6u1dUtsWdw47+t/H9r5XtXS+SjHwT+hgprWI5tJanG8h8=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPg7H-0005oA-QM; Mon, 13 Sep 2021 09:11:02 +0200 In-Reply-To: <87zgshotc1.fsf@gmail.com> (Augusto Stoffel's message of "Mon, 13 Sep 2021 08:58:06 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214178 Archived-At: Augusto Stoffel writes: > I thought 'insert-file-contents-literally' literally just inserted the > file contents, as bytes, but I noticed that in the following code > > (create-image > (with-temp-buffer > (set-buffer-multibyte nil) > (insert-file-contents-literally "picure.jpg") > (buffer-substring-no-properties (point-min) (point-max))) > nil t) > > the call to 'set-buffer-multibyte' is really essential. In what way? If the first byte in a binary file is #xff, inserting the file literally in a buffer and saying `(following-char)' on the first character in the buffer will say #xff. But, yes, when dealing with octet streams, it's a lot less confusing if you're using unibyte buffers (and strings). > Is this intended? If so, I think a note in the doctring is due. The doc string doesn't say anything about bytes, so I think that's an interpretation on your side. `insert-file-contents-literally' does insert "literally" -- but the byte contents of the internal buffer structure can't be violated (emacs uses utf-8 (plus extensions) for multibyte buffers). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no