From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50690: Avoid double argument evaluation in vc-call Date: Tue, 21 Sep 2021 12:53:43 +0100 Message-ID: <875yuum9fc.fsf@tcd.ie> References: <87pmt49lfe.fsf@tcd.ie> <87r1diecav.fsf@gnus.org> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14393"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50690@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 21 13:54:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSeLn-0003W9-Gz for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Sep 2021 13:54:15 +0200 Original-Received: from localhost ([::1]:39386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSeLm-0000Nw-1v for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Sep 2021 07:54:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSeLa-0000Lz-G4 for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2021 07:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33570) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSeLa-0001Uy-8a for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2021 07:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mSeLa-0004fu-3a for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2021 07:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Sep 2021 11:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50690 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50690-submit@debbugs.gnu.org id=B50690.163222523717957 (code B ref 50690); Tue, 21 Sep 2021 11:54:02 +0000 Original-Received: (at 50690) by debbugs.gnu.org; 21 Sep 2021 11:53:57 +0000 Original-Received: from localhost ([127.0.0.1]:45116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSeLV-0004fZ-BQ for submit@debbugs.gnu.org; Tue, 21 Sep 2021 07:53:57 -0400 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:36519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSeLP-0004ev-UK for 50690@debbugs.gnu.org; Tue, 21 Sep 2021 07:53:54 -0400 Original-Received: by mail-wr1-f48.google.com with SMTP id g16so38345526wrb.3 for <50690@debbugs.gnu.org>; Tue, 21 Sep 2021 04:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=zO526v0UbS9zBKzadGbf9zfsiSAHVUBC1933jhVcnyk=; b=b4JzCyWy2tp98uwgkia3UQ7xEEkyeXxu1VkE0jD0T4i1AvfRpYzYGdPVBqw0w3BgAk ptLHK2Dd+28zP5GOUYirZb21FVzw9/qy9YdPlU4dBBhub50JvaQ04M+8DM4xhDR0dX/u btKREq9VH1VN6oKjzlBaQ+HgVZcrKxHbv7bNPHR7X1TfN8Yunl3PH3U12AFTg02lIhcO pv5rIuTJWU2/Cns2BRl8E5UuNHGDhMZrnDbUgcTXOBG79W7z7nJhtdSSoOneHNiI1R25 ZS6YmtZuBA5rQRsvPq75heKsxF5ZJMl6YkIIRdAbydv+lC8cIrSmLrbscbWZb7kLxhlx jeqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=zO526v0UbS9zBKzadGbf9zfsiSAHVUBC1933jhVcnyk=; b=yrjsPz4rkfBL1QJTDFc2EupRDD3WOEDw+b0tLkLWqORamOKd8UgirH9zf0rNvF2KHo hMiXElkX5CrYcMF57qd7adwYT2yx7BFAy1kEySjx7rUZHdOMRO95BdNB+sJj9wXYivSe rwIovQLwLTM3rmKeP9awNJcoaxM3w8WjMTsYXayzhTTPz9tq464W62n80MBCTfptr4QC rXwLMvzWfesfjz9utobxpRMiyiLu5q4IlUpjJZWm+TygoCfsO1xd5qLBcv+a95s34WZ0 znA9RgaJrsavKIg4WsbV4Z3ygQmiRXWkx8y5i9TUiFeFm6qTt4bjcPwIFBQbTk2JaArg KW5g== X-Gm-Message-State: AOAM530hZwttkB38YRhh3+2TnI8HPCKBbur7JAGorE0VWLIAZfFF7a0R jc0WeS33TCzLdWSnkyB1Uvl7k8Pw4CFFaQ== X-Google-Smtp-Source: ABdhPJx6ZbCe0KCFikx8wb2vSDR6ddyKVVFtF4nGcSOnzGqq0yI6zMsYnRiMnhxLhqItxTOtwtwkvQ== X-Received: by 2002:a1c:7714:: with SMTP id t20mr4081348wmi.163.1632225225881; Tue, 21 Sep 2021 04:53:45 -0700 (PDT) Original-Received: from localhost ([80.233.54.48]) by smtp.gmail.com with ESMTPSA id x5sm3496823wmk.32.2021.09.21.04.53.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Sep 2021 04:53:45 -0700 (PDT) In-Reply-To: <87r1diecav.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 21 Sep 2021 07:18:48 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214958 Archived-At: close 50690 28.1 quit Lars Ingebrigtsen [2021-09-21 07:18 +0200] wrote: > "Basil L. Contovounesios" writes: > >> Is there any reason why the macro vc-call should continue to evaluate >> its second argument twice? Both 'make bootstrap' and 'make check' pass >> with the attached patch: > > Your patch seems "obviously correct" to me (but it's an incompatible > change since the previous wonky behaviour was actually documented, so it > should be mentioned in NEWS). Done: Avoid double argument evaluation in vc-call macro 5b962a7ad8 2021-09-21 12:30:58 +0100 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=5b962a7ad8d0acfe40a41ce139059b9c8e46f666 I wasn't sure which is the most appropriate heading for it, so I put it under * Changes in Specialized Modes and Packages in Emacs 28.1 ** Change Logs and VC Would * Incompatible Lisp Changes in Emacs 28.1 be more appropriate? Thanks, -- Basil