From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 50690@debbugs.gnu.org
Subject: bug#50690: Avoid double argument evaluation in vc-call
Date: Tue, 21 Sep 2021 12:53:43 +0100 [thread overview]
Message-ID: <875yuum9fc.fsf@tcd.ie> (raw)
In-Reply-To: <87r1diecav.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 21 Sep 2021 07:18:48 +0200")
close 50690 28.1
quit
Lars Ingebrigtsen [2021-09-21 07:18 +0200] wrote:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> Is there any reason why the macro vc-call should continue to evaluate
>> its second argument twice? Both 'make bootstrap' and 'make check' pass
>> with the attached patch:
>
> Your patch seems "obviously correct" to me (but it's an incompatible
> change since the previous wonky behaviour was actually documented, so it
> should be mentioned in NEWS).
Done:
Avoid double argument evaluation in vc-call macro
5b962a7ad8 2021-09-21 12:30:58 +0100
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=5b962a7ad8d0acfe40a41ce139059b9c8e46f666
I wasn't sure which is the most appropriate heading for it, so I put it
under
* Changes in Specialized Modes and Packages in Emacs 28.1
** Change Logs and VC
Would
* Incompatible Lisp Changes in Emacs 28.1
be more appropriate?
Thanks,
--
Basil
next prev parent reply other threads:[~2021-09-21 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-19 23:48 bug#50690: Avoid double argument evaluation in vc-call Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-21 5:18 ` Lars Ingebrigtsen
2021-09-21 11:53 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-09-21 16:57 ` Lars Ingebrigtsen
2021-09-21 17:17 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yuum9fc.fsf@tcd.ie \
--to=bug-gnu-emacs@gnu.org \
--cc=50690@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).