From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key Date: Tue, 19 Oct 2021 15:24:12 +0200 Message-ID: <875yttf8qr.fsf@gnus.org> References: <87bl4jvudm.fsf@gnus.org> <837dehp248.fsf@gnu.org> <87czo96shw.fsf@gnus.org> <87wnmh5bes.fsf@gnus.org> <87wnmh3p9k.fsf@gnus.org> <87v91tfzrw.fsf@gnus.org> <87r1chfz80.fsf@gnus.org> <83r1chcjof.fsf@gnu.org> <87mtn5fc9s.fsf@gnus.org> <83bl3lchrp.fsf@gnu.org> <87ee8hfajg.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17221"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: stefan@marxist.se, shuguang79@qq.com, 50752@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 19 15:27:46 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcp9d-0004Gf-Mr for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 15:27:45 +0200 Original-Received: from localhost ([::1]:33952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcp9c-0007hh-Gx for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 09:27:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52230) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcp70-0005rC-BV for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 09:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38311) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcp70-0000JE-0S for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 09:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mcp6z-0006x3-ON for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 09:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2021 13:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50752-submit@debbugs.gnu.org id=B50752.163464986726675 (code B ref 50752); Tue, 19 Oct 2021 13:25:01 +0000 Original-Received: (at 50752) by debbugs.gnu.org; 19 Oct 2021 13:24:27 +0000 Original-Received: from localhost ([127.0.0.1]:49857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcp6R-0006wA-Bi for submit@debbugs.gnu.org; Tue, 19 Oct 2021 09:24:27 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:35016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcp6P-0006vx-TZ for 50752@debbugs.gnu.org; Tue, 19 Oct 2021 09:24:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Sgx+aGy926SvL0e5RfRiKS4/+mLFtDuR9VvtANu5vv8=; b=JOZZ2iR93QzuLy/OazVfTUVaYI 9oDUhDkxQaE5dDgKqKDzjw59cyuLYw93yzrqcXxT4bQhHYl75RjKcjzu5mE9Phy+jHL0AdHX91CWs 0TSn6Iw4Xher5Apqw0oSdC4/WY7EqzK67dHBQ1CY7M8i3JigdqpYLzqK5dUOMMi4nI+E=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcp6G-0006Ie-0k; Tue, 19 Oct 2021 15:24:18 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUiFxxzjJeWqbBi d4xKTVe0v8fR09r///86u1foAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+UKEw0SLi67Lg4AAAGjSURB VDjLnZNRkoMgDIaZlgsoewHTpc+rOPtslQvITLgB3P8Im0RQ2/FpU6fM5DN//gAqRdG6cYGujTln xEgPLUqAcQ5MTyAm5IdWAdC5vnEDpShS5n+p0CGY3jgQkSR6G7jFwCUWKZcT6yACg9/8RGgABFAf qgABmzaA3dIJAwi455TYJLIhfge6RsBMNjcrSTA0HAWQBINNktJmJPB6ihvKsSbpN854v4MsQ3AB gUkXIGJYDHWiw8CWARhCoP2ZdhB3gO8Aa01iU0VJDWfApn4qAIv2aNKZoqR6sGDjrtVVJfUC3tiU CoGqpBYGtH+lJkwnwO0LSGsFfg4Mahf8VjsgXQylIoVpr1hyBm6Dcn0e+gA2Bj5MayOGdfQV6GXI fESWf2H92k0p38aygdRnPfJKb9dDzjWM6hQzxCQFtOVv4A4g+w0tjNMZ6LmzNAsd6u6orPrRA5jD KBmqq8RZpCye0XQBJmJv4PSKW/wluPEM7qJIy0fxuCBDoDvbfgC+wjS+8Z9t5G7PYJrxyoAeqP2l ZSLN+JHbXtS9uZ5l6/Xv+AMd4re+5ctE/AAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0xMC0xOVQx MzoxODo0NiswMDowMDEI1aUAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMTAtMTlUMTM6MTg6NDYr MDA6MDBAVW0ZAAAAAElFTkSuQmCC X-Now-Playing: Rocket To The Sky's _Medea_: "Song Of Pearl" In-Reply-To: <87ee8hfajg.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 19 Oct 2021 14:45:23 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217574 Archived-At: Lars Ingebrigtsen writes: > Nope. The loop can just check whether we get a multibyte result when > downcasing unibyte (ASCII), and then defer to the multibyte version to > do the computation. I.e., this change, which even passes all the case tests: diff --git a/src/casefiddle.c b/src/casefiddle.c index a7a2541490..b46d42f5e2 100644 --- a/src/casefiddle.c +++ b/src/casefiddle.c @@ -310,11 +310,12 @@ do_casify_unibyte_string (struct casing_context *ctx, Lisp_Object obj) cased = case_single_character (ctx, ch); if (ch == cased) continue; - cased = make_char_unibyte (cased); - /* If the char can't be converted to a valid byte, just don't - change it. */ - if (SINGLE_BYTE_CHAR_P (cased)) - SSET (obj, i, cased); + /* If downcasing changed an ASCII character into a non-ASCII + character (this can happen in some locales, like the Turkish + "I"), use the multibyte algorithm. */ + if (SINGLE_BYTE_CHAR_P (ch) && !SINGLE_BYTE_CHAR_P (cased)) + return do_casify_multibyte_string (ctx, obj); + SSET (obj, i, make_char_unibyte (cased)); } return obj; } It's a wonder that Emacs works at all in a Turkish environment -- I instrumented the function and made it spit out every time it translated "I" to "1" during startup, and it was a huge stream of Got multi: jISX0208.1983-0 Got multi: bIG5-0 Got multi: jISX0208.1983-0 Got multi: jISX0208.1983-0 Got multi: bIG5-0 Got multi: jISX0208.1983-0 Got multi: bIG5-0 Got multi: jISX0208.1983-0 etc. But I guess it doesn't trip up anything really vital. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no