From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51821: 29.0.50; Suggest add variable or frame parameter: line-height Date: Mon, 15 Nov 2021 06:39:15 +0100 Message-ID: <875ysu2d18.fsf@gnus.org> References: <87bl2nhbyp.fsf@163.com> <83bl2nugao.fsf@gnu.org> <878rxq62qt.fsf@gnus.org> <83k0hatxjl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1455"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: tumashu@163.com, 51821@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 15 06:40:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmUix-0000Fw-BQ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Nov 2021 06:40:11 +0100 Original-Received: from localhost ([::1]:57862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmUiv-0000yX-QQ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Nov 2021 00:40:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmUio-0000yP-MP for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2021 00:40:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40687) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmUio-0005Tc-Df for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2021 00:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mmUio-0006yl-7r for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2021 00:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Nov 2021 05:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51821 X-GNU-PR-Package: emacs Original-Received: via spool by 51821-submit@debbugs.gnu.org id=B51821.163695476726772 (code B ref 51821); Mon, 15 Nov 2021 05:40:02 +0000 Original-Received: (at 51821) by debbugs.gnu.org; 15 Nov 2021 05:39:27 +0000 Original-Received: from localhost ([127.0.0.1]:52233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmUiF-0006xk-GA for submit@debbugs.gnu.org; Mon, 15 Nov 2021 00:39:27 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:40038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmUiD-0006xS-C4 for 51821@debbugs.gnu.org; Mon, 15 Nov 2021 00:39:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/BXjSoage/L0Nuomh839JUo8D9TYoSRuaaZHHM1jYjU=; b=QZ2dfbh/5OkF5Eu+e6jS9oC9j8 FOpIxA1zavYNWxZMEG4EY0O/vRfrMTOylp1M4z40jCh32i1C219VmlYvkoauxgCNiRDYU48/dTrzi ioEM2BKQDZQvu/knPDRgBhjUU25y5PRi8lShfDDpW0lfALdCz94UtfjXCL/EAAduSz70=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmUi4-00025k-2g; Mon, 15 Nov 2021 06:39:18 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEXt7Oy4s6ZpZWH/ //+RkaxBAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+ULDwUOAD2m7rMAAAEwSURBVCjPVZHNasMwDMel YQ22kwN1Djnv0jyFC+nOHjg59DYog+Yp9hBNoTtn0OQpJ8lxyEwg+unDkv4G2J4GTbNlu1o7MEEN 10Zxe7G9fBaN2KhowSwFAmt5BCgCbCIZNCWlGYW15CP9XExNc7/luF79wdfzA8o5ehnA16cMnLvv GSZJwyKnaSDB7SpwUKi+Rk0DhVkAVkhNBVxYJhAN/h128Ob7X3WjJtlPVFA9igGR3RIJUDwR3hgG 1huK7o6zBzqykOC6u2HDeFGhfI944Ug03LX8udJbYN0MTlCfRuJZROsG6n5U0UgaGec3U3lajKo7 W9FHgxVv3iG1+gTVEPEb6KDwysAXpcjLFLHN8NymiF5AAoF4Y+5LkXdGSnrQeQeer9ZnJK60qsEy lOryB5/VRMvdQ4b+AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTExLTE1VDA1OjE0OjAwKzAwOjAw gYRj0AAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0xMS0xNVQwNToxNDowMCswMDowMPDZ22wAAAAA SUVORK5CYII= X-Now-Playing: Aksak Maboul's _Redrawn Figures 1_: "Hotel Suites (Carl Stone Redesign)" In-Reply-To: <83k0hatxjl.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 14 Nov 2021 20:14:06 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220029 Archived-At: Eli Zaretskii writes: >> I think... a natural interpretation would be that explicit :height >> specs would override the line-height variable/parameter? > > But line-height is not a variable or parameter, it is just a text > property, and it needs to be put on a newline to change the height of > that single line. So currently this is up to the Lisp program: if it > puts this property on some line, the visual results is its > responsibility. I was talking about the line-height variable only here, not the text property. > By contrast, a buffer-local variable or a frame parameter are global: > they apply to all lines, tall and small alike. And users will use > this variable/parameter globally as well. Thus its effect on lines > that use smaller fonts is something to be concerned about. > > My impression is that this is wanted only for the default face, and > then only for the ASCII font of that face. That could be done, I > think, but (a) it will probably not work with text-scaling and other > remappings of the default faces, and (b) some faces other than default > also need this, definitely the mode-line and header-line, but also > fixed-pitch perhaps? > > So I'm stuck trying to figure out what exactly are the requirements > here. It has to work across different fonts -- I think that's the real use case here, that if you're missing different fonts (which you commonly are when writing with different scripts), then the Emacs display gets pretty messy (uneven line heights all over the place). So here's how I think the `line-height' variable should work: * After redisplay has composed a line, it should check whether the line height is less than `line-height', and if so, add empty space at the bottom (or the top, or perhaps both, to center it). ** But -- if the line is composed purely of text with a face with an explicit :height property, it should do nothing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no