From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51891: 29.0.50; [PATCH] Pixel delta support for wheel events on X Date: Wed, 17 Nov 2021 08:34:43 +0800 Message-ID: <875ysrtyak.fsf@yahoo.com> References: <87zgq4uvh0.fsf.ref@yahoo.com> <87zgq4uvh0.fsf@yahoo.com> <871r3gnrrn.fsf@gmail.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29621"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: 51891@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 17 01:42:52 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mn92K-0007XN-LM for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Nov 2021 01:42:52 +0100 Original-Received: from localhost ([::1]:56914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mn92J-0006wU-DF for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Nov 2021 19:42:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mn8uk-0007fB-IJ for bug-gnu-emacs@gnu.org; Tue, 16 Nov 2021 19:35:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47916) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mn8uk-000730-97 for bug-gnu-emacs@gnu.org; Tue, 16 Nov 2021 19:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mn8uk-0001ff-3q for bug-gnu-emacs@gnu.org; Tue, 16 Nov 2021 19:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Nov 2021 00:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51891 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51891-submit@debbugs.gnu.org id=B51891.16371092986407 (code B ref 51891); Wed, 17 Nov 2021 00:35:02 +0000 Original-Received: (at 51891) by debbugs.gnu.org; 17 Nov 2021 00:34:58 +0000 Original-Received: from localhost ([127.0.0.1]:59462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mn8ug-0001fG-H1 for submit@debbugs.gnu.org; Tue, 16 Nov 2021 19:34:58 -0500 Original-Received: from sonic314-21.consmr.mail.ne1.yahoo.com ([66.163.189.147]:32877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mn8ue-0001ey-6u for 51891@debbugs.gnu.org; Tue, 16 Nov 2021 19:34:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1637109290; bh=5wiJZfi+jbmhi5J+Of0AER75wjopNYwX0pdUt4CbgXc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=S8+uUng1uAc3CykBCXoftmoaJtd4BVmqL1vr09i+2R2ichMvtqZIAJ5QG/TPWWuoMhkyFqXGHOjAqxXyYGULFdJZI7g8fkh28vfbwX9TPUI/8RhR65neoKEhgNeCRW7SItPU00h+yEOCl/6OZI5ktM/4F5y8J/N9Ili1NtNWm6Mi19VjwOCYSF6iwj77Qc/Y4F0EjFZ56vPxFkn3lr39rfvK1G7RV7eHgjUFBJDyVlUXjcMrZlet87pBwVTKUuVTZejc6GiOVLmtAfGynWqPGFfyB7ACfBtL+l9268h3kzJ6OQyP/+AF4u4K8wRrTwHyAYI7LmnV5CRkxo/VUOvJIQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1637109290; bh=LIgw3kUa1paP/kuoPFfgwNbYuJQ29OKD5j0XDbhVayc=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=uflMONsjv3FwgnVl7ZDdPSQV3gzUXMagoAPXWE/tHQWRAQIDgQ7HAfB0b8nVaMAkw6fz+qP7t+HYGw23EiG17ExzMnIHW41iMyppZzFxGl889LSlPsIRLJ3eHTnQRs7IPGw7g47Pr0wQA9Wi+8SLBmrNpQOIG+UJHWCYzUM0hJR7AoCyXV+ncQeCLKijDC6JkaHJUwqsMdxkwDwX914y7eUFr0V1WxVkScygmsjqFVJZaml8dS2mZivCsO6olZYSLT6a+0yms3/vlcMN8ZaJveNUcZNMLfKoxoPUDCZxYBXEMV2y6kyVo5/j5hgm4ZEHfgm55WxZXQe9bhozhjbYNA== X-YMail-OSG: AKsw5tMVM1mNHmVm98avOF8cS5doinimVRAoOq77o_aUbtUC7Kem3XGoV92i6xL Hib0UsuJ57AJL8M67AN8T4CW2mY7XRhi0hQQ4o2TORtsqQoJojkEcEeAboObydGS342fdlEZeiap NfF6Wmoekq6Xa7SZjuZ0ZsxU3zO6hm03aKr0qBs5fhDGmj5gH6VmO8vYRGSyQkRzIbYxKuWNBnWq ZFedyzd6o4Pj0ZMGGnfkyhEXYD5xBZ8Gn6XwIVGzyiynZdZ98gfQ_OL7GXmpoZ8rWtYDFh74oFkR wIEyn5K0agnQwlzGcHFg_bxHho5cCOq4AuYVqM8iDmBK_lxxv.R.9TGYFPZXBEkxux0l_VOU92y5 Jjo01cpDjq4raJ6.j.jULwa.qfsC.xcXMcueQndbjz5lkXNom3Qws1XBAXkQwIgvuXy34ZDTgMVr .Vhqp38Hl52cTQljPuRuTjlAp3J91yxjgNgybsYdCh6OgZT0EDWfnQv6uTZyrbhkHXyR08fFcmjp _PPtPlPnj8MSxuj.t7zgxEsryUw2pQ55ZqZFTUWIVp_iKihH7cJaORYldRO8EGn._Hxg9UZVAQnR om0StbqOiKLwl2q.CFqnT.LHdQUOuN3gLhCxSCna4k1s5NgxHCOGoWpuQ5qRWcz9nF6cWsecxUcs jCsLwQ8bnMcKEY0YQPMy_TckrjmF8Pun5bNKsDp_JjmRj5SetrQ8rGbjoXZqHPaq5VulO2PV8ToZ aKF7A2MxnLT9SE0qY.WrQdlaIoEPU668jtBnVeWp3FdLVu1XzV.7y89u098KY1E2PAx..GJFtOe8 DGRYzFnPTVYSJsrSeJTzxaJjlaao1FL8V1wGckc6CF X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Wed, 17 Nov 2021 00:34:50 +0000 Original-Received: by kubenode511.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 61637422c20cbd548b74e57a2b12ef5c; Wed, 17 Nov 2021 00:34:46 +0000 (UTC) In-Reply-To: <871r3gnrrn.fsf@gmail.com> (Robert Pluim's message of "Tue, 16 Nov 2021 14:39:56 +0100") X-Mailer: WebService/1.1.19306 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220169 Archived-At: Robert Pluim writes: > Is there really a need for this to be a plist with :delta-x and > :delta-y in it? Just a cons of x and y would work. Yes, what if other window systems decide to expose different values to Lisp code? Such as for example, the phase of the scroll. > I don=CA=BCt think this is quite right. The 'X' is missing, and it=CA=BCs= 'X' > and 'Y' that give the number of pixels. And :delta-x and :delta-y > (lowercase). Thanks, I fixed that on my side. > So the :delta-y value is always 0 when :delta-x is non-zero and vice > versa? Why bother to return both then? (and why floats and not ints?). Because other systems (such as GDK) have different methods of reporting scroll deltas. While it makes sense in the context of the XInput 2 code to report them one at a time, it does not in the context of GDK, as it reports both deltas to Emacs at the same time. Which means the pure GTK port will report both delta-y and delta-x at the same time. Thanks.