From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#52010: 28.0.60; ERC now ignores dialed server names in autojoin Date: Sun, 21 Nov 2021 17:43:23 -0800 Message-ID: <875ysl3qys.fsf__14463.3510777325$1637545460$gmane$org@neverwas.me> References: <87ilwmbbz7.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16603"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: emacs-erc@gnu.org To: 52010@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 22 02:44:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moyNQ-00046C-Vr for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Nov 2021 02:44:13 +0100 Original-Received: from localhost ([::1]:46326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moyNP-0003GI-Qi for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Nov 2021 20:44:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36210) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moyNG-0003G7-9B for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2021 20:44:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34854) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moyNF-00071V-PZ for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2021 20:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moyNF-0005hX-OM for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2021 20:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Nov 2021 01:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52010 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52010-submit@debbugs.gnu.org id=B52010.163754542021876 (code B ref 52010); Mon, 22 Nov 2021 01:44:01 +0000 Original-Received: (at 52010) by debbugs.gnu.org; 22 Nov 2021 01:43:40 +0000 Original-Received: from localhost ([127.0.0.1]:46400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moyMt-0005gl-Q1 for submit@debbugs.gnu.org; Sun, 21 Nov 2021 20:43:40 -0500 Original-Received: from mail-108-mta113.mxroute.com ([136.175.108.113]:35821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moyMr-0005gN-Ln for 52010@debbugs.gnu.org; Sun, 21 Nov 2021 20:43:38 -0500 Original-Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta113.mxroute.com (ZoneMTA) with ESMTPSA id 17d454fedd5000177f.001 for <52010@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Mon, 22 Nov 2021 01:43:25 +0000 X-Zone-Loop: 023a9991cb70985cf53610371aa7ee46fc20c0fae9bf X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=n1xqLavKE21xeKMwae/AVoHCGznTAqyy/t56rlI9U4I=; b=e023+DkBvpxdQ2Ov1yG1coksID 9JYjR3vL7IUOkO7mpZ3jd6II3QhQEAGnqUkdEmEMxgqdN8NS08WZScK+uFCJK45uDaLSlDHOiNqRo wk8W0L6c2QeYFQjh8nOasFuBJ56Jc5HKsmbHuaPQYGkI9Mif8Y2Ppno4kV6o/7KL0WcgCBeiKmHYV M4Ngi3Ljvo92JDlGQyQgJ8c2ZOccXzNGtPLur1kqex6N+y4Q0j/DZEilGGl+3qNxu3y65wG+J1Z0u GaTAY7WgvNww01FmTTK95suXqcye3Hwi9ohNzUNaRuwHji3a/4dRGGM4cvVXR6ZcJSzqPlvLmI3TK xqSa7l0g==; In-Reply-To: <87ilwmbbz7.fsf@neverwas.me> (J. P.'s message of "Sat, 20 Nov 2021 16:15:24 -0800") X-AuthUser: masked@neverwas.me X-Zone-Spam-Resolution: no action X-Zone-Spam-Status: No, score=-0.1, required=15, tests=[ARC_NA=0, FROM_HAS_DN=0, MIME_GOOD=-0.1, TO_DN_NONE=0, NEURAL_SPAM=0, RCPT_COUNT_TWO=0, RCVD_COUNT_ZERO=0, FROM_EQ_ENVFROM=0, MIME_TRACE=0, MID_RHS_MATCH_FROM=0] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220602 Archived-At: Actually, please ignore everything stated previously (and the patch as well). The 2017 change [1] was *not* the source of the problem as wrongly implied in my previous email (although it did get the ball rolling by changing from announced to dialed names for auth-source queries). The real culprit is actually something way more recent [2]: diff --git a/lisp/erc/erc-join.el b/lisp/erc/erc-join.el index e4faf6bd79..79c111082f 100644 --- a/lisp/erc/erc-join.el +++ b/lisp/erc/erc-join.el @@ -153,18 +153,20 @@ erc-autojoin-channels 'erc-autojoin-channels-delayed server nick (current-buffer)))) ;; `erc-autojoin-timing' is `connect': - (dolist (l erc-autojoin-channels-alist) - (when (string-match (car l) server) - (let ((server (or erc-session-server erc-server-announced-name))) + (let ((server (or erc-session-server erc-server-announced-name))) + (dolist (l erc-autojoin-channels-alist) + (when (string-match-p (car l) server) But its damage has already been undone by [3] (IOW, there's no regression)! So everything's fine as long as we don't mind a bit of churn for folks on master who may have adjusted their autojoin alists in the meantime (since August 2020 or so). I suppose if we *really* wanted to be thorough, we could add an entry to etc/ERC-NEWS saying a problem introduced in early in Emacs-28 development has been fixed and that any entries in `erc-autojoin-channels-alist' containing dialed host names as keys should use networks or partial announced domains instead. But, IMO, that's unnecessary. Thanks, and apologies (yet again) for the noise. [1] commit 927dcbd2e6e0e53fcfb09296716e11c002ab1518 Fix erc-join with channel password [2] commit 88567ca8ecb505a59157af6338ebe355a304182b Fix erc-reuse-buffers behavior [3] commit 9bb8d90cddf11df3aecdc6c04e762773dfa0cb92 Allow irc network symbols in erc-autojoin-channels-alist