From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: dick Newsgroups: gmane.emacs.bugs Subject: bug#52302: 28.0.50; [PATCH] Overlay strings should not increment vpos Date: Mon, 06 Dec 2021 14:47:45 -0500 Message-ID: <875ys1ikgu.fsf@dick> References: <87v903hs0w.fsf@dick> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39094"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/28.0.50 (gnu/linux) To: 52302@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 06 20:48:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1muJyC-0009zj-U0 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Dec 2021 20:48:16 +0100 Original-Received: from localhost ([::1]:40372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1muJyB-0008Tz-GY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Dec 2021 14:48:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muJxy-0008Oc-TY for bug-gnu-emacs@gnu.org; Mon, 06 Dec 2021 14:48:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52175) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1muJxy-000097-LU for bug-gnu-emacs@gnu.org; Mon, 06 Dec 2021 14:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1muJxy-000507-Hr for bug-gnu-emacs@gnu.org; Mon, 06 Dec 2021 14:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: dick Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Dec 2021 19:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52302 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52302-submit@debbugs.gnu.org id=B52302.163882007619195 (code B ref 52302); Mon, 06 Dec 2021 19:48:02 +0000 Original-Received: (at 52302) by debbugs.gnu.org; 6 Dec 2021 19:47:56 +0000 Original-Received: from localhost ([127.0.0.1]:35488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muJxs-0004zW-4r for submit@debbugs.gnu.org; Mon, 06 Dec 2021 14:47:56 -0500 Original-Received: from mail-qv1-f52.google.com ([209.85.219.52]:34392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muJxq-0004yv-R1 for 52302@debbugs.gnu.org; Mon, 06 Dec 2021 14:47:55 -0500 Original-Received: by mail-qv1-f52.google.com with SMTP id i13so10941255qvm.1 for <52302@debbugs.gnu.org>; Mon, 06 Dec 2021 11:47:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=QBZftdIMd1NraTwOU5u6X4WkKCwKIUs7+Sm7yUn1Uhc=; b=WK9tgz+KGLbfk46S+qPpfZzdF5K5Rmjs+cOCceH5qYE/PM5Q59+emWrIsTY+E19iz1 kCL03Vn6kGX6aXpI8gYoqxM2w7Ss/fgxpwta6md8yaMOoEXwih8lCohiKlDyztuy6Um5 BsmHSgFNpp3JqY+1miDCFXDd26ZOvrwk/Mz34u1ZwKOqFqOM+3hy0Uon56XKVcGqT8AZ sD9AzWqxJpkAVuzGJJB9h6gTDkAj1pU50mzLHi6y01JNo5iNTvbtcFR8fo/SW91+/NHL Uq1nUDP/Q3UAXxlEaoDCaKHrGb7vKz28rK7Bvtzj+CsCBIuQqk3VCU3d7vRwXuDQAYk3 fAQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=QBZftdIMd1NraTwOU5u6X4WkKCwKIUs7+Sm7yUn1Uhc=; b=1RUmMLHpcAh6q3U2QiUWiFstPhK3Ybx+J7fMr0z5yYEkvQ92gnRx8CE1c2UZzmphoG xGJGcn0om/1T3+Uca46ledYRFsuOxON25lrgKcOB/Occlmnlw9tIEHXL4A9V1xLmZpNL i9zm9F2smdO9Zrp+R80gO4rIcDFIlRg42pTvJXMe66b6F3pYu7B1IJoMhZwb0To6bgqs +6YUL4GsS/UpBVQK8J3p1S8y3+nX1XHQh3PtJm32JQcxviNtqORSMFq3m1tWE/aA3roo kWZj0m+IxrN6xsE8ybr+9MqKfsgYujNTZegNXWNZYMNcHTrBgvtodg6pI0Ee8sVsvkmH m+oA== X-Gm-Message-State: AOAM531T9GO8a6dF0zV/QY3eJa5QbMFjYzdUhV8yWPVW9e3YtYveVsSb 1Pfhqi/UIFYpwXLa51CEj9gwVd/JIkg= X-Google-Smtp-Source: ABdhPJwR8tW08Qf+NENvCe/wBVc45wx8ZtxquC/sMKWwemRACEpdPSLcf79ydUHSRSl6H7OpK2IP6A== X-Received: by 2002:a05:6214:2a84:: with SMTP id jr4mr39798823qvb.35.1638820068938; Mon, 06 Dec 2021 11:47:48 -0800 (PST) Original-Received: from localhost ([68.237.93.126]) by smtp.gmail.com with ESMTPSA id x4sm8239342qtw.44.2021.12.06.11.47.46 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Dec 2021 11:47:46 -0800 (PST) In-Reply-To: <87v903hs0w.fsf@dick> (dick r. chiang's message of "Sun, 05 Dec 2021 12:37:35 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221784 Archived-At: --=-=-= Content-Type: text/plain A more dangerous change like the below would break the cycle of fixes that minimize impact while maximizing obfuscation. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-A-small-change-with-disastrous-potential.patch >From 5f734c1d50953836dda444b8371642c6f20d4065 Mon Sep 17 00:00:00 2001 From: dickmao Date: Mon, 6 Dec 2021 14:30:17 -0500 Subject: [PATCH] A small change with disastrous potential * src/xdisp.c (move_it_in_display_line_to): How this function has managed to get by without a notion of visibility is a real mystery. --- src/xdisp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xdisp.c b/src/xdisp.c index 0ff6286af74..1522c6b3193 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -9561,7 +9561,7 @@ #define IT_RESET_X_ASCENT_DESCENT(IT) \ PRODUCE_GLYPHS (it); - if (it->area != TEXT_AREA) + if (it->area != TEXT_AREA || it->method == GET_FROM_STRING) { prev_method = it->method; if (it->method == GET_FROM_BUFFER) -- 2.26.2 --=-=-= Content-Type: text/plain I'll explore this more deeply in my longlines rewrite. In the meantime, closing. --=-=-=--