From: dick <dick.r.chiang@gmail.com>
To: 52302@debbugs.gnu.org
Subject: bug#52302: 28.0.50; [PATCH] Overlay strings should not increment vpos
Date: Mon, 06 Dec 2021 14:47:45 -0500 [thread overview]
Message-ID: <875ys1ikgu.fsf@dick> (raw)
In-Reply-To: <87v903hs0w.fsf@dick> (dick r. chiang's message of "Sun, 05 Dec 2021 12:37:35 -0500")
[-- Attachment #1: Type: text/plain, Size: 122 bytes --]
A more dangerous change like the below would break the cycle of fixes
that minimize impact while maximizing obfuscation.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-A-small-change-with-disastrous-potential.patch --]
[-- Type: text/x-diff, Size: 808 bytes --]
From 5f734c1d50953836dda444b8371642c6f20d4065 Mon Sep 17 00:00:00 2001
From: dickmao <dick.r.chiang@gmail.com>
Date: Mon, 6 Dec 2021 14:30:17 -0500
Subject: [PATCH] A small change with disastrous potential
* src/xdisp.c (move_it_in_display_line_to): How this function has
managed to get by without a notion of visibility is a real mystery.
---
src/xdisp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/xdisp.c b/src/xdisp.c
index 0ff6286af74..1522c6b3193 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -9561,7 +9561,7 @@ #define IT_RESET_X_ASCENT_DESCENT(IT) \
PRODUCE_GLYPHS (it);
- if (it->area != TEXT_AREA)
+ if (it->area != TEXT_AREA || it->method == GET_FROM_STRING)
{
prev_method = it->method;
if (it->method == GET_FROM_BUFFER)
--
2.26.2
[-- Attachment #3: Type: text/plain, Size: 83 bytes --]
I'll explore this more deeply in my longlines rewrite. In the meantime, closing.
next prev parent reply other threads:[~2021-12-06 19:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 17:37 bug#52302: 28.0.50; [PATCH] Overlay strings should not increment vpos dick.r.chiang
2021-12-05 18:34 ` Eli Zaretskii
2021-12-05 18:52 ` dick
2021-12-05 19:06 ` dick
2021-12-05 19:47 ` Eli Zaretskii
2021-12-05 22:10 ` dick
2021-12-06 19:47 ` dick [this message]
2021-12-06 20:02 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ys1ikgu.fsf@dick \
--to=dick.r.chiang@gmail.com \
--cc=52302@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).