From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#52380: ERT, buffers and windows (was: bug#52380: 28.0.50; [PATCH] run-python no longer focuses interpreter) Date: Fri, 10 Dec 2021 21:09:30 +0100 Message-ID: <875yrw9q85.fsf_-_@gmail.com> References: <87pmq666cb.fsf@gmail.com> <874k7gzmto.fsf@gnus.org> <87y24sy863.fsf@gnus.org> <87a6h89s7p.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40389"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52380@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 10 21:10:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvmDk-000AMf-7p for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Dec 2021 21:10:20 +0100 Original-Received: from localhost ([::1]:38672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvmDi-0007of-IS for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Dec 2021 15:10:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvmDT-0007nl-5N for bug-gnu-emacs@gnu.org; Fri, 10 Dec 2021 15:10:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36406) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mvmDS-0007oe-IX for bug-gnu-emacs@gnu.org; Fri, 10 Dec 2021 15:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mvmDS-0002Mz-8b for bug-gnu-emacs@gnu.org; Fri, 10 Dec 2021 15:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Dec 2021 20:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52380 X-GNU-PR-Package: emacs Original-Received: via spool by 52380-submit@debbugs.gnu.org id=B52380.16391669809078 (code B ref 52380); Fri, 10 Dec 2021 20:10:02 +0000 Original-Received: (at 52380) by debbugs.gnu.org; 10 Dec 2021 20:09:40 +0000 Original-Received: from localhost ([127.0.0.1]:47952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvmD6-0002MM-1R for submit@debbugs.gnu.org; Fri, 10 Dec 2021 15:09:40 -0500 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:38839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvmD3-0002M7-Es for 52380@debbugs.gnu.org; Fri, 10 Dec 2021 15:09:39 -0500 Original-Received: by mail-wr1-f46.google.com with SMTP id q3so16802978wru.5 for <52380@debbugs.gnu.org>; Fri, 10 Dec 2021 12:09:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=t5+CPiUupsQxgQfo3gx7q7ZCz5PZYd8RrXZqD9jIQJI=; b=BFdUJME00TWPh2ZA/+rIZHQMNvteRArdEMja3Phu2odzxS5/YUtOVTZbzo1hZ7tu7E wDv5GpM33AGeJg1IyUc01JAH6Jowd8Ma5j5sOxtu0BYRTxsbscfHFzfMragkshkvOk2m ZHyk3M2ufhz/epxdk0LEjiQUQh9foSp9HI/1ZoxCNgYKre4F7APOGEiz7XfrHHiZ6AT+ HpMhwAk5uN0OKXJU33alZ9vQOYLjT1N28v7+oRDg5V84FSfudUheku4DIYJVDp2Gljjz cd6aeJYWk8juSSNR9jsQ6j5t3669txngtFY0oFTWUCLMNS8BQT4ibGz/5Oy81fASElUI Bx9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=t5+CPiUupsQxgQfo3gx7q7ZCz5PZYd8RrXZqD9jIQJI=; b=VmAPkFrnhjRwqcOAuqJynLP6vOnKIOPwCK7ZTPl1DeA36bykdI1Ec5TmYEXeNXDgy7 N863Ew6IOe5ERFWJ8QTDRhX2r3cO/p8xD1GURdJfCreCILbUWDe/4709aufVtQd8y1WW elFks6U2eJNh8/ea8dRxDlbGPJZiMloHPmfDuv3x2aCJevK9RDS/z18hPlJGQOo3LtZ+ QZYaq0uoap4FdPYiO0Ux5c6pS0OqaDuqAG1Hk2aGbFzbpYNV7GVObj7K9lWpdHPV3fF/ MBt9bzdxH18Rt9OfeOVr7pUrp/J3WgiVxAE9+3rf1PT8HzHELTaByi+E9Au9JLH0V0F8 PkWA== X-Gm-Message-State: AOAM533SFh2xU1z/lWAjEQEzC07OG28ezQxUfdIduR3MpZCoLSC8GJAp MuD0IImS0aUP+CEANOJO165uNoI080A= X-Google-Smtp-Source: ABdhPJylCYpTFVbDFU2auRs445gv7YbKG+30os/WZcXoHSyMrPpMQ9kmbChM3wb82hD9/xwzQb3Liw== X-Received: by 2002:a05:6000:1c8:: with SMTP id t8mr934831wrx.542.1639166971066; Fri, 10 Dec 2021 12:09:31 -0800 (PST) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id t16sm3259796wrn.49.2021.12.10.12.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Dec 2021 12:09:30 -0800 (PST) In-Reply-To: <87a6h89s7p.fsf@gmail.com> ("=?UTF-8?Q?K=C3=A9vin?= Le Gouguec"'s message of "Fri, 10 Dec 2021 20:26:34 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222089 Archived-At: K=C3=A9vin Le Gouguec writes: > Lars Ingebrigtsen writes: > >> Lars Ingebrigtsen writes: >> >>> Makes sense to me; pushed to emacs-28. >> >> But then I reverted it, because it led to a test failure, so could you >> have a look at that? > > Well great; I meant to write a test case for that eventually. > > Assuming you mean python-tests--bug31398? That's the one I'm seeing > failing with my patch. > > I've banged my head on it for an hour now; I don't understand what's > going on. The test case is checking precisely what I was trying to fix, > and for some reason the set-buffer I removed does something that the > pop-to-buffer I replaced it with doesn't. > > What set-buffer does not, of course, is actually work in interactive > usage =F0=9F=98=92 If I amend the test as follows: diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/pyth= on-tests.el index 15bda5c197..783f115fc7 100644 --- a/test/lisp/progmodes/python-tests.el +++ b/test/lisp/progmodes/python-tests.el @@ -5454,6 +5454,7 @@ python-tests--bug31398 "Test for https://debbugs.gnu.org/31398 ." (skip-unless (executable-find python-tests-shell-interpreter)) (let ((buffer (process-buffer (run-python nil nil 'show)))) + (should (eq (get-buffer-window buffer) (selected-window))) (should (eq buffer (current-buffer))) (pop-to-buffer (other-buffer)) (run-python nil nil 'show) =E2=80=A6 then (should (eq (get-buffer-window buffer) (selected-window))) passes, but (should (eq buffer (current-buffer))) does not. Does that make sense to anyone?