From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Date: Thu, 28 Apr 2022 16:14:56 +0200 Message-ID: <875ymt70jl.fsf@fastmail.fm> References: <87wnfa3cop.fsf@fastmail.fm> <87czh2qpkc.fsf@gmail.com> <86bkwly9qy.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10168"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.7.13; emacs 29.0.50 Cc: Juri Linkov , No Wayman , 55149-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 28 16:20:49 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nk50h-0002RF-4f for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 16:20:48 +0200 Original-Received: from localhost ([::1]:43594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nk50f-0006fQ-Lx for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 10:20:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk4zz-0006cz-42 for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 10:20:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55611) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nk4zy-0002La-OJ for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 10:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nk4zy-00030p-FH for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 10:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2022 14:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55149-done@debbugs.gnu.org id=D55149.165115559411561 (code D ref 55149); Thu, 28 Apr 2022 14:20:02 +0000 Original-Received: (at 55149-done) by debbugs.gnu.org; 28 Apr 2022 14:19:54 +0000 Original-Received: from localhost ([127.0.0.1]:49508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4zq-00030P-0m for submit@debbugs.gnu.org; Thu, 28 Apr 2022 10:19:54 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:51707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4zo-00030B-1k for 55149-done@debbugs.gnu.org; Thu, 28 Apr 2022 10:19:52 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id BF1B05C00F5; Thu, 28 Apr 2022 10:19:45 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 28 Apr 2022 10:19:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651155585; x=1651241985; bh=Ig5PbJr796 Z4DuEw76oYcSGU4o0jAY2L+5Nd8cmEr2U=; b=DF6SmUGvgvMoMtSl8oEDVUuHpJ GMdeIIm4FlAPBQa0sqanjdFY/ltmNLOsQa42GBwHGSgWbSkrELbkAZftDXmDotWm sl13Oa0CbK3SAG/YjP/gqrssLV895vJ715QRkeUq8eRbKrU70Yfy8DHBKZaAwTmy hhqB4v8EFR9rNrxmwhOvsYKeomd6yTM5ptgT7FdRVsXF1h2bW04PJ99LRy2naNfg GhhEY6oU32HVzBxMJ/KaoHgNPy07GqXjfzijPC8X9MwZrdREaAIkaccGMGOVxjm+ JHkIE8Uw3vjT3ZWJf03Pk1F56sWYIBFj93h8Zxo4e34fgPTtGbH5jyhx2Uwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651155585; x= 1651241985; bh=Ig5PbJr796Z4DuEw76oYcSGU4o0jAY2L+5Nd8cmEr2U=; b=j 4y46HX2JY2IdaoJUehij38jx1pgoIOTF68FF7VUSxbM5FWduwB7FwvqaZoLgEn+7 oAoxlU4YY3k8NN3fj8J319PLypg6gKiiGCiJVY/jYXyeJxIAf0rjVVQrCwGQL3Fk AQF2kNKjy10fA4Lqmul/ostCtCh6Ggz3feLcH3b/mciTbzgz5p1TXbJ8VfoOjboJ EhboL9FJttutGiElnQq4lOuBLCc0HaeIwVA/6Ckc8ajiJGehorosv0yTcmlUIfuk 3PY39v6+/lpUFJsfsrhdZn5sFVmvMi8rDdCrznLr3VM93V/EubGksaNe4QzHhVsz 0911b2sScw/wnxUIXNCZg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejgdejhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehthhhorhhnsehfrghsthhmrghilhdrfhhmqeenucggtffrrghtth gvrhhnpeegffeihfejkeeuieeuheettefgheetgfffgeefudehjeeihffgheetkeethfdv gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthh horhhnsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Apr 2022 10:19:44 -0400 (EDT) In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230883 Archived-At: Stefan Monnier writes: >> I have the same problem, and distilled it to the shortest test case: >> >> ``` >> (defun testa () >> 1) >> >> (advice-add 'testa :after >> (lambda (&rest _) 2)) >> >> (defun testb () >> (interactive) >> (message "! %S" (testa))) >> ``` > > Thanks, should be fixed now, It is, thanks. Shouldn't you also adapt the add-function docstring? Oh, that's adapted automatically! Interesting approach. And even more interesting that the info docs were correct since 2014. :-) Bye, Tassilo