From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#5352: diff-jump-to-old-file inverts hunk application as well Date: Mon, 09 May 2022 16:32:11 +0200 Message-ID: <875yme6al0.fsf@gnus.org> References: <4B4AAB78.7030102@orlitzky.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6115"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 5352@debbugs.gnu.org To: Michael Orlitzky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 09 16:41:38 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1no4Zt-0001Mr-Pw for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 16:41:37 +0200 Original-Received: from localhost ([::1]:59752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1no4Zs-0004np-CK for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 10:41:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no4Ra-0000kW-OB for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 10:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36923) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1no4Ra-0003OT-DR for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 10:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1no4Ra-00007g-9V for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 10:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 May 2022 14:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5352 X-GNU-PR-Package: emacs Original-Received: via spool by 5352-submit@debbugs.gnu.org id=B5352.165210675131470 (code B ref 5352); Mon, 09 May 2022 14:33:02 +0000 Original-Received: (at 5352) by debbugs.gnu.org; 9 May 2022 14:32:31 +0000 Original-Received: from localhost ([127.0.0.1]:59053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no4R5-0008BC-05 for submit@debbugs.gnu.org; Mon, 09 May 2022 10:32:31 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:42882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no4Qw-0007za-I5 for 5352@debbugs.gnu.org; Mon, 09 May 2022 10:32:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LeVioaotoAfgmDE9Ry1wHAhNagG2wJ3IO63OP3FyoAA=; b=Zc10nu1dUud7yZMY9A7vkSbJp4 L3ewFGVYz3ADePTO0B1ESXrxZucerqg2qaHrNbkNZ62kE0K4bsOwLQR/htJv4XCZzUhNHZ9PZ5F56 VJonuer+fshnSmD0y4SOb21x6SmkfhtJLk+HbS3EGlBLlgTLjQkANk+P+gMDgKL6o8AI=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1no4Qm-0006on-Ce; Mon, 09 May 2022 16:32:14 +0200 X-Now-Playing: King Crimson's _Beat_: "Waiting Man" In-Reply-To: <4B4AAB78.7030102@orlitzky.com> (Michael Orlitzky's message of "Sun, 10 Jan 2010 23:39:20 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231750 Archived-At: Michael Orlitzky writes: > The custom diff-jump-to-old-file causes a reversal of the traditional > diff/patch behavior present in Emacs <= 22. From diff-mode.el, it seems > sort of intentional that this is the case; nevertheless, the new > behavior does not strike me as useful. From diff-mode.el: > > (defun diff-apply-hunk (&optional reverse) > "Apply the current hunk to the source file and go to the next. > By default, the new source file is patched, but if the variable > `diff-jump-to-old-file' is non-nil, then the old source file is > patched instead (some commands, such as `diff-goto-source' can change > the value of this variable when given an appropriate prefix argument). > > Why should the default be to patch the new file, which is by definition > already patched? Take for example, (I'm going through old bug reports that unfortunately weren't resolved at the time.) I think the logic here is when you have a diff that's been partially applied, so that the "new" file isn't literally the one you've already applied the patch to. In that case, you usually want to apply the hunk to the new file, and not the old one. In any case, the current behaviour has been in place for a decade, so I think it's too late to change it now (because that would break things for people that's used to the direction it works in now). So I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no