From: Lars Ingebrigtsen <larsi@gnus.org>
To: "João Pedro" <jpedrodeamorim@gmail.com>
Cc: 55754@debbugs.gnu.org
Subject: bug#55754: 28.1; rcirc-define-command interactive spec doesn't work
Date: Thu, 02 Jun 2022 11:33:18 +0200 [thread overview]
Message-ID: <875ylj1kbl.fsf@gnus.org> (raw)
In-Reply-To: <87zgiwxt3u.fsf@gmail.com> ("João Pedro"'s message of "Wed, 01 Jun 2022 13:10:13 -0300")
João Pedro <jpedrodeamorim@gmail.com> writes:
> When using `rcirc-mode', I realized that some of the commands weren't
> working as expected. After a bit of inspection, I realized that the
> macro `rcirc-define-command' was defined in such as a way that the
> interactive spec for the functions generated by such macro always have
> the form `(list ...)'.
This was fixed in Emacs 29 by this commit:
commit 5df658a96a4bc7f8f96e3b2bf58dad32f81ce06a
Author: Philip Kaludercic <philipk@posteo.net>
AuthorDate: Tue Apr 19 13:16:51 2022 +0200
Fix handling of intspecs as string by rcirc-define-command
* rcirc.el (rcirc-define-command): Check if an interactive
specification is a string, in which case it was to be wrapped in a
list so that the result of its interpretation is passed as the first
argument of the command resulting from the macro expansion.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-06-02 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 16:10 bug#55754: 28.1; rcirc-define-command interactive spec doesn't work João Pedro
2022-06-02 9:33 ` Lars Ingebrigtsen [this message]
2022-06-03 1:12 ` João Pedro
2022-06-03 3:24 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ylj1kbl.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=55754@debbugs.gnu.org \
--cc=jpedrodeamorim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).