From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) Date: Mon, 22 Aug 2022 14:42:31 +0000 Message-ID: <875yik49ic.fsf@posteo.net> References: <878rng23aq.fsf@posteo.net> <877d30bmki.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3351"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57334@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 22 17:55:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ9m5-0000d0-9f for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Aug 2022 17:55:37 +0200 Original-Received: from localhost ([::1]:52562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQ9m3-0003qF-Vm for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Aug 2022 11:55:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQ9Gv-0007G1-Dj for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 11:23:25 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51732) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQ9Gv-00074X-3T for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 11:23:25 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oQ8mY-0002ya-0L for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 10:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Aug 2022 14:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57334 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 57334-submit@debbugs.gnu.org id=B57334.166117988911397 (code B ref 57334); Mon, 22 Aug 2022 14:52:01 +0000 Original-Received: (at 57334) by debbugs.gnu.org; 22 Aug 2022 14:51:29 +0000 Original-Received: from localhost ([127.0.0.1]:41443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8m0-0002xl-TJ for submit@debbugs.gnu.org; Mon, 22 Aug 2022 10:51:29 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:58527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8lv-0002xU-FW for 57334@debbugs.gnu.org; Mon, 22 Aug 2022 10:51:27 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id DC9FB24002C for <57334@debbugs.gnu.org>; Mon, 22 Aug 2022 16:51:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661179876; bh=smONrUsYhC7plU00HJ7y7QuenX28goDILMgV/OB37Ok=; h=From:To:Cc:Subject:Date:Autocrypt:OpenPGP:From; b=JTODczDjFriY55MKQYKGqnk4nGe5ti7F5/eW7Mvu5zKxw6aesKyj27FbqN1jFHPJV T7Zo1xX+MYk//n8eDfR6ku1lLfvdGxEyZYI2DGiAjLcsVTKT9zXBlEdOzScvlSf7s6 afktEmvoJWBXXsszPhW0EPHpibhZrYI5o/3zeB65nCyJEA/xa2qoZCiG/tXpKMuLBg ruVOaB09E4V+SiYgPWBhd/3ZxHooGor9lMEl7ATbegjKh9nUhiNhg5FZYJv/prTU5D sKZyv+wj9NAwsHMEj6synqvlkGBYf1uYChVzrZVtPHCWmEpVZYH3ZBWZNurk0MxPd1 fFGOHkTQxrCOw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MBFfp4Q09z9rxh; Mon, 22 Aug 2022 16:51:13 +0200 (CEST) In-reply-to: <877d30bmki.fsf@gnus.org> Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQa OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240435 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Lars Ingebrigtsen writes: > Thierry Volpiatto writes: > >> + (setcdr dired-directory >> + ;; Replace in `dired-directory' files that have >> + ;; been modified with their new name keeping >> + ;; the ones that are unmodified at the same pl= ace. >> + (cl-loop for f in (cdr dired-directory) >> + collect (or (assoc-default f files-re= named) >> + f))))) > > This isn't obviously safe -- I think you're changing the list that > `dired' was originally called with here, Of course it have to be changed, it has been modified by wdired at this poi= nt, so if you want to redisplay a dired buffer reflecting your changes you have to modify it no ? > which we shouldn't do. You already do it when DIRNAME is a string isn't it? > (It may even be a constant.) Can you elaborate? > So I think this should be changed to not do that. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmMDl9sTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk8txC/wMCXW9u/HO2ChnNpUX3pEKzJnguHl2 3j27Nodo8G893TmlQyDeM75yoUugezc9rsp5ZIHIWimqPd1fuhmenwAnJTuxRUM2 Ajwp6PrlbIuuRT0YDlZSG/89h+v6+fwphg/MqhRrP6VTRIoXlU/NoWY7DGwpY6JL 9ivUM0nsGsxR1vub4KVvFFUBYFAv4tV03I++M1pPWrmTnTyzfJ6v1omCh/XcoGOI odyrc0/xoEI3l3KC/LhQxiS1pV3fT3CNd29EQcsJbZbcBtuDdBG8Ic3lNfE5AvWg YVNohYlrQeV0lcuW3ihzHe2g2BVBQl2PzREvdk+VpojVSqAdUWoheLTyTrLULy7c l+QI1fLTB19HJuIOseshvZFd71aGBilmDa8Q9mnYbfermJJcU+oHPDU3KDLgVoZt tPWXNGZDxG9vUQ2iUcSfpZoJE9zZp8nHqVQljGFGDAg/hJSN3dZL7xAQpBhfQ1xh n7L8xMz8z8pz1YptINULlHzzg8i8Or4YqbA= =yn5l -----END PGP SIGNATURE----- --=-=-=--