From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Wed, 07 Sep 2022 13:31:18 +0000 Message-ID: <875yhzl3a1.fsf@posteo.net> References: <875yhzmz25.fsf@posteo.net> <875yhzmj50.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20220"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57639@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 07 15:32:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVvA5-00051P-Ot for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Sep 2022 15:32:13 +0200 Original-Received: from localhost ([::1]:46146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVvA4-00036s-P9 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Sep 2022 09:32:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVv9v-000354-4U for bug-gnu-emacs@gnu.org; Wed, 07 Sep 2022 09:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37143) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVv9u-0006EW-FN for bug-gnu-emacs@gnu.org; Wed, 07 Sep 2022 09:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVv9u-000863-3g for bug-gnu-emacs@gnu.org; Wed, 07 Sep 2022 09:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Sep 2022 13:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.166255748831081 (code B ref 57639); Wed, 07 Sep 2022 13:32:02 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 7 Sep 2022 13:31:28 +0000 Original-Received: from localhost ([127.0.0.1]:54075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVv9L-00085F-Qq for submit@debbugs.gnu.org; Wed, 07 Sep 2022 09:31:28 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:35509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVv9K-000850-Ep for 57639@debbugs.gnu.org; Wed, 07 Sep 2022 09:31:27 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 1A361240026 for <57639@debbugs.gnu.org>; Wed, 7 Sep 2022 15:31:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662557480; bh=HIU+75GVxcrye2ziwVLc/9xykkmn/yHY23XjIeYmaok=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=CtRaYuib/psSMe6nbUMoX9Fur+N8ix1hs2zXfGWqqQTTgTjUXQUYSIcg1ajIPFaP+ DapAO21Lvav6mo/XNCDIQtAHG8jFMEaXvHf6p2Szmq1BjHyobGPI9/DeYiOZSJXGFJ prUTFxRD0Y1uZCQ+VjczLVq6fQ6Qk5nyOGrzgjmB8yDtJTx6J30SnZ0gHKEQk1GqDH TsFi3UT+hIFTfqnZwpje9yl7IGVOpWoEW9LTYUimlMmCEORJhV50gAxzJdS3E0wS4E LgFh1j/xzgOkR5SI4tP+tdqCqq6M3WQOEL+38/I5GB79avONiIGlJbkdN6EQU56M+d FJxNLyLxv9dQQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MN37C1Qf8z9rxV; Wed, 7 Sep 2022 15:31:18 +0200 (CEST) In-Reply-To: <875yhzmj50.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 07 Sep 2022 15:03:23 +0200") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241775 Archived-At: Lars Ingebrigtsen writes: > Philip Kaludercic writes: > >> Find below a patch for a command that a lot of custom themes >> re-implement, whenever there exists a light and dark variant. > > I think it would also be nice if the themes themselves explicitly > defined themselves as being light/dark, really. That way, when Emacs > finally grows a "react to the OS dark mode settings", Emacs could also > flip to the correct theme (if we have a dual theme). Do you think it would be better to less general, and instead of talking about "dual" themes always assume we want to toggle between a light and a dark variant? If not, this sounds like a separate feature (say that could be handled by a different property `theme-variant').