From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Mon, 12 Sep 2022 11:06:45 +0000 Message-ID: <875yhsrgvu.fsf@posteo.net> References: <875yhzmz25.fsf@posteo.net> <875yhzmj50.fsf@gnus.org> <875yhzl3a1.fsf@posteo.net> <87fsh25bso.fsf@gnus.org> <871qsil3jm.fsf@posteo.net> <87fsgygo7c.fsf@gnus.org> <87a676jfx2.fsf@posteo.net> <87bkrmdt46.fsf@gnus.org> <8735cxpx2r.fsf@posteo.net> <871qsgc390.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36462"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , 57639@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 12 13:09:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXhJX-0009Hh-Rl for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Sep 2022 13:09:19 +0200 Original-Received: from localhost ([::1]:47366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXhJU-0006dR-J3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Sep 2022 07:09:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXhHP-0006ZJ-IF for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2022 07:07:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oXhHK-0006DV-AL for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2022 07:07:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oXhHK-0004YE-2j for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2022 07:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Sep 2022 11:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.166298081817485 (code B ref 57639); Mon, 12 Sep 2022 11:07:02 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 12 Sep 2022 11:06:58 +0000 Original-Received: from localhost ([127.0.0.1]:44291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXhHG-0004Xx-2u for submit@debbugs.gnu.org; Mon, 12 Sep 2022 07:06:58 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:52597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXhHD-0004Xi-1m for 57639@debbugs.gnu.org; Mon, 12 Sep 2022 07:06:57 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 9E2D7240101 for <57639@debbugs.gnu.org>; Mon, 12 Sep 2022 13:06:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662980808; bh=rfV3Jyrj5+O1ugIM+6JwsYOxJhUE7FGNDvYQQ+Q1Aiw=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=VskzHmt85ZQDI1mhj+COyP7nCRbj+NP3hfO0ZusnwPCAlPLKCrypWQtpO19yS1k0+ frESUsqVq8K+eHdoTosnr30cPUPpZddd2EgXOZMwR3C/jtaMzbv1IQcpdsOGkXE35v YmQS/YOy+6Mj7MkztB5bLildlgtVrgV8Gwt16hjIQMUqXJH9uHclS/lJij/WUfLxsc TD2nX26fZLIyRReYR/wZPYMBNDhnssD9HqXiLfuVdXCIhUPaoLAiZGon2B6DwKlwl5 d3P33t2lXF0ZvVMOOqIl5eCV9l136FnHKCfDCuyIEPRoYzXpe9XR+uYRHAHDCMdJ+r 0zg1uVZfVCCSA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MR3h61wwXz6tqh; Mon, 12 Sep 2022 13:06:46 +0200 (CEST) In-Reply-To: <871qsgc390.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 12 Sep 2022 12:10:19 +0200") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242232 Archived-At: Lars Ingebrigtsen writes: > Philip Kaludercic writes: > >>> I thought we already had support for this under Gtk? But I may be >>> misremembering. >> >> Am I reading it correctly that `style_changed_cb' in gtkutils.c would be >> a place to start looking for this functionality? > > Ah, yes, I think that's the one... Po Lu probably know more about this; > added to the CCs. > >> So would gruvbox-soft-dark have all the other themes as variants or only >> gruvbox-soft-dark?=20=20 > > Well, I was saying that the term "variants" isn't really what we need > here, but tagging themes for features. > > So gruvbox-soft-dark would say > > (theme-featues :name 'gruvbox :mode 'dark :softness 'soft) > > or... feature names that make more sense. =F0=9F=98=80 > > Then the `theme-change-feature' if you have a gruvbox theme enabled > would give you three other themes to choose from. > > If there's just the dark/light difference, then there's only one other > theme to choose from, and no prompting would be needed. OK, now I understand what confused me. It certainly sounds interesting, I just wonder what "features" there really are, or should it be kept open-ended (i.e. any theme can specify any number of attributes)?