From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#57884: [PATCH] Flymake backend using the shellcheck program Date: Sun, 18 Sep 2022 09:52:31 +0200 Message-ID: <875yhlt8zk.fsf@gmail.com> References: <87a66yaqwc.fsf@gmail.com> <83bkre0w4m.fsf@gnu.org> <871qs9c3er.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1327"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , 57884@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 18 09:53:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZp7O-0000DL-Ib for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Sep 2022 09:53:34 +0200 Original-Received: from localhost ([::1]:40598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZp7N-0004qZ-Bw for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Sep 2022 03:53:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZp6s-0004Rw-Jn for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 03:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48630) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZp6s-0007AO-BS for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 03:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oZp6r-0008Gq-RV for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 03:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Sep 2022 07:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57884 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57884-submit@debbugs.gnu.org id=B57884.166348756331766 (code B ref 57884); Sun, 18 Sep 2022 07:53:01 +0000 Original-Received: (at 57884) by debbugs.gnu.org; 18 Sep 2022 07:52:43 +0000 Original-Received: from localhost ([127.0.0.1]:47708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZp6Z-0008GI-1F for submit@debbugs.gnu.org; Sun, 18 Sep 2022 03:52:43 -0400 Original-Received: from mail-ed1-f47.google.com ([209.85.208.47]:33514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZp6V-0008G0-Lg for 57884@debbugs.gnu.org; Sun, 18 Sep 2022 03:52:42 -0400 Original-Received: by mail-ed1-f47.google.com with SMTP id b35so37102334edf.0 for <57884@debbugs.gnu.org>; Sun, 18 Sep 2022 00:52:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date; bh=7T0euHAb1k7wY04V+YQ5vThMQNYjZAxIZQBSFN2Ib3k=; b=Q2bgp8MMvT8GRc0dpw7aYW7aZY+Yr75xMWuWIezcOCnZ0RA33PK96Qw7Gi0h7q6ihZ 1u5kXVaPzsEQkO7yLJKofI8fp31VQQL6Cr5OhkJolVzNDDXYoy4avmWxGiJmJgyifh6m Q+IUE9blO6zJ6WXYJjWpq5F1YxF4ioyQ8T4mHD8//zsRg8Jy7hGhWoXESMMta7zKxaGW 0+/6s4uB4UYIZjG5w2ss237fUYrSqBFqJiWqxTLaBuJh72YYc8lin1ARKjsME/Cu2ZFj +KWgrZaQcorIIR3EiqK4zhi1/7rMCiLmMqHZMcEq5oApUwuIYlyiMcQoFRhWcn1vaER3 p0AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=7T0euHAb1k7wY04V+YQ5vThMQNYjZAxIZQBSFN2Ib3k=; b=c5GEf3T+pHKqvMqoMo0GShGL4Lant66W/a7fpD5woEHU2jXoRtBn44wr04QY8q+/BE CNF/Nf7I/66YtN5raufHUiU+n9xiG7Y1/h5J1FqYgPFKVEGD3DEzFfPwAc9J6c+7QVCA 2RKsQVL0R0rLia5OG1VqCE1RIiTOV8tg062N5A6Fm8357TLW+H2FV2OHHvlReTkBGl+K T/J80VFTJm+ubFP8KTRSUUejTX2p7TAgcSpkZz6vnA4l/mlcb8sLD4n8FotwxuzWRS4z Hwzbi2y0owlCThVlOWvUBMKL+pe4MaID+3dHUevNuj+OAuJq7PK/kb14rqvIjpQBthIq sK+Q== X-Gm-Message-State: ACrzQf3zuIzDiJIbE/D/Tt+8U6/mguVaVWogoq8fb5pSQjpe3mlZ+10x 3iE+Tz1sizRARN3jFlH6DSn2oyA/ZU4ENw== X-Google-Smtp-Source: AMsMyM6VzHcpFbMHjn1UqxTLZaGiR8+vVa9NpJyCKWHE3/S9SzgNEETE+2LAQhNc+rVyc9uElBGsjA== X-Received: by 2002:a05:6402:5168:b0:44e:9ca8:bf6 with SMTP id d8-20020a056402516800b0044e9ca80bf6mr10704115ede.384.1663487553287; Sun, 18 Sep 2022 00:52:33 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::8510]) by smtp.gmail.com with ESMTPSA id o23-20020a17090611d700b007341663d7ddsm13411982eja.96.2022.09.18.00.52.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Sep 2022 00:52:32 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Sat, 17 Sep 2022 14:04:05 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242935 Archived-At: On Sat, 17 Sep 2022 at 14:04, Stefan Kangas wrote: > Augusto Stoffel writes: > >> I could split this into two defcustoms if you feel strongly about it, >> but it seems a bit of overengineering to me. Not many people will want >> to customize the program name, and the switches would have to be >> provided as a list anyway, since we're not going to call this through a >> shell. > > FWIW, I tend to agree, unless we can point to any other "shellcheck" > compatible programs out there. For now, the code assumes that's what > we're using, right? Yes, this Flymake backend is specific to this particular program because 1. the output pattern is probably more or less unique, 2. it needs a dynamically computed argument and 3. Flymake allows several backends to in parallel, so if a new linter comes into being, it's up to the user to decide whether to run one or the other or both.